fix(langchain_v1): ToolNode initialization uses tool attributes in create_agent for middleware #33282
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
keenborder786
commented
Oct 5, 2025
keenborder786
commented
- Description: The additional attributes of tools are not being passed when it is an instance of ToolNode, which causes buggy behavior for clients creating agents with middleware. Also when differentiating between regular and built-in tools, it's better if we check using BaseTool instance.
- Issue: The Tool error handling is not working if the Agent created with middleware #33153
github-actions
bot
added
langchain
|
@sydney-runkle @eyurtsev please review |
keenborder786
changed the title
keenborder786
changed the title
|
Closing this as maintainers have remove tool to be an instance of |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.