fix(sdk): code hygiene (#1357)

Author: dqbd

.changeset/few-spies-bet.md

@@ -0,0 +1,5 @@
+---
+"@langchain/langgraph-sdk": patch
+---
+
+Add missing optional peer dependency on react-dom

libs/sdk/.eslintrc.cjs

@@ -0,0 +1,78 @@
+module.exports = {
+  extends: [
+    "airbnb-base",
+    "eslint:recommended",
+    "prettier",
+    "plugin:@typescript-eslint/recommended",
+    "plugin:react-hooks/recommended-legacy",
+  ],
+  parserOptions: {
+    ecmaVersion: 12,
+    parser: "@typescript-eslint/parser",
+    project: "./tsconfig.json",
+    sourceType: "module",
+  },
+  plugins: ["@typescript-eslint", "no-instanceof"],
+  ignorePatterns: [
+    ".eslintrc.cjs",
+    "scripts",
+    "node_modules",
+    "dist",
+    "dist-cjs",
+    "*.js",
+    "*.cjs",
+    "*.d.ts",
+  ],
+  rules: {
+    "no-process-env": 2,
+    "no-instanceof/no-instanceof": 2,
+    "@typescript-eslint/explicit-module-boundary-types": 0,
+    "@typescript-eslint/no-empty-function": 0,
+    "@typescript-eslint/no-shadow": 0,
+    "@typescript-eslint/no-empty-interface": 0,
+    "@typescript-eslint/no-use-before-define": ["error", "nofunc"],
+    "@typescript-eslint/no-unused-vars": ["warn", { args: "none" }],
+    "@typescript-eslint/no-floating-promises": "error",
+    "@typescript-eslint/no-misused-promises": "error",
+    "arrow-body-style": 0,
+    camelcase: 0,
+    "class-methods-use-this": 0,
+    "import/extensions": [2, "ignorePackages"],
+    "import/no-extraneous-dependencies": [
+      "error",
+      { devDependencies: ["**/*.test.ts", "**/*.test-d.ts"] },
+    ],
+    "import/no-unresolved": 0,
+    "import/prefer-default-export": 0,
+    "keyword-spacing": "error",
+    "max-classes-per-file": 0,
+    "max-len": 0,
+    "no-await-in-loop": 0,
+    "no-bitwise": 0,
+    "no-console": 0,
+    "no-empty-function": 0,
+    "no-restricted-syntax": 0,
+    "no-shadow": 0,
+    "no-continue": 0,
+    "no-void": 0,
+    "no-underscore-dangle": 0,
+    "no-use-before-define": 0,
+    "no-useless-constructor": 0,
+    "no-return-await": 0,
+    "consistent-return": 0,
+    "no-else-return": 0,
+    "func-names": 0,
+    "no-lonely-if": 0,
+    "prefer-rest-params": 0,
+    "new-cap": ["error", { properties: false, capIsNew: false }],
+  },
+  overrides: [
+    {
+      files: ["src/tests/**/*.ts"],
+      rules: {
+        "no-instanceof/no-instanceof": 0,
+        "@typescript-eslint/no-explicit-any": 0,
+      },
+    },
+  ],
+};

libs/sdk/package.json

@@ -8,8 +8,11 @@
     "build": "yarn turbo:command build:internal --filter=@langchain/langgraph-sdk",
     "build:internal": "yarn clean && yarn lc_build --create-entrypoints --pre --tree-shaking",
     "prepack": "yarn run build",
+    "format:check": "prettier --check src",
     "format": "prettier --write src",
-    "lint": "prettier --check src",
+    "lint:eslint": "NODE_OPTIONS=--max-old-space-size=4096 eslint --cache --ext .ts,.js,.jsx,.tsx src/",
+    "lint": "yarn lint:eslint",
+    "lint:fix": "yarn lint:eslint --fix",
     "test": "vitest run",
     "typedoc": "typedoc && typedoc src/react/index.ts --out docs/react --options typedoc.react.json && typedoc src/auth/index.ts --out docs/auth --options typedoc.auth.json"
   },
@@ -29,6 +32,15 @@
     "@types/react": "^19.0.8",
     "@types/react-dom": "^19.0.3",
     "@types/uuid": "^9.0.1",
+    "@typescript-eslint/eslint-plugin": "^6.12.0",
+    "@typescript-eslint/parser": "^6.12.0",
+    "eslint": "^8.33.0",
+    "eslint-config-airbnb-base": "^15.0.0",
+    "eslint-config-prettier": "^8.6.0",
+    "eslint-plugin-import": "^2.29.1",
+    "eslint-plugin-no-instanceof": "^1.0.1",
+    "eslint-plugin-prettier": "^4.2.1",
+    "eslint-plugin-react-hooks": "^5.2.0",
     "prettier": "^2.8.3",
     "react": "^19.0.0",
     "react-dom": "^19.0.0",
@@ -37,14 +49,18 @@
   },
   "peerDependencies": {
     "@langchain/core": ">=0.2.31 <0.4.0",
-    "react": "^18 || ^19"
+    "react": "^18 || ^19",
+    "react-dom": "^18 || ^19"
   },
   "peerDependenciesMeta": {
     "@langchain/core": {
       "optional": true
     },
     "react": {
       "optional": true
+    },
+    "react-dom": {
+      "optional": true
     }
   },
   "exports": {

libs/sdk/src/auth/error.ts

@@ -65,6 +65,7 @@ const HTTP_STATUS_MAPPING: { [key: number]: string } = {
 
 export class HTTPException extends Error {
   status: number;
+
   headers: HeadersInit;
 
   constructor(

libs/sdk/src/auth/index.ts

@@ -9,7 +9,7 @@ import type {
 } from "./types.js";
 
 export class Auth<
-  TExtra = {},
+  TExtra = {}, // eslint-disable-line @typescript-eslint/ban-types
   TAuthReturn extends BaseAuthReturn = BaseAuthReturn,
   TUser extends BaseUser = ToUserLike<TAuthReturn>
 > {

libs/sdk/src/auth/types.ts

@@ -98,7 +98,7 @@ interface ThreadDelete {
  */
 interface ThreadSearch {
   thread_id?: Maybe<string>;
-  status?: Maybe<"idle" | "busy" | "interrupted" | "error" | (string & {})>;
+  status?: Maybe<"idle" | "busy" | "interrupted" | "error" | (string & {})>; // eslint-disable-line @typescript-eslint/ban-types
   metadata?: Maybe<Record<string, unknown>>;
   values?: Maybe<Record<string, unknown>>;
   limit?: Maybe<number>;
@@ -330,7 +330,7 @@ type CallbackParameter<
   Event extends string = string,
   Resource extends string = string,
   Action extends string = string,
-  Value extends unknown = unknown,
+  Value = unknown,
   TUser extends BaseUser = BaseUser
 > = {
   event: Event;

libs/sdk/src/client.ts

@@ -49,6 +49,7 @@ function* iterateHeaders(
   let iter: Iterable<(HeaderValue | HeaderValue | null[])[]>;
   let shouldClear = false;
 
+  // eslint-disable-next-line no-instanceof/no-instanceof
   if (headers instanceof Headers) {
     const entries: [string, string][] = [];
     headers.forEach((value, name) => {
@@ -62,7 +63,7 @@ function* iterateHeaders(
     iter = Object.entries(headers ?? {});
   }
 
-  for (let item of iter) {
+  for (const item of iter) {
     const name = item[0];
     if (typeof name !== "string")
       throw new TypeError(
@@ -263,7 +264,7 @@ class BaseClient {
       for (const [key, value] of Object.entries(mutatedOptions.params)) {
         if (value == null) continue;
 
-        let strValue =
+        const strValue =
           typeof value === "string" || typeof value === "number"
             ? value.toString()
             : JSON.stringify(value);
@@ -345,7 +346,7 @@ export class CronsClient extends BaseClient {
     assistantId: string,
     payload?: CronsCreatePayload
   ): Promise<CronCreateForThreadResponse> {
-    const json: Record<string, any> = {
+    const json: Record<string, unknown> = {
       schedule: payload?.schedule,
       input: payload?.input,
       config: payload?.config,
@@ -377,7 +378,7 @@ export class CronsClient extends BaseClient {
     assistantId: string,
     payload?: CronsCreatePayload
   ): Promise<CronCreateResponse> {
-    const json: Record<string, any> = {
+    const json: Record<string, unknown> = {
       schedule: payload?.schedule,
       input: payload?.input,
       config: payload?.config,
@@ -879,7 +880,7 @@ export class ThreadsClient<
 
     return this.fetch<void>(`/threads/${threadId}/state`, {
       method: "PATCH",
-      json: { metadata: metadata },
+      json: { metadata },
     });
   }
 
@@ -973,7 +974,7 @@ export class RunsClient<
     TUpdateType,
     TCustomEventType
   > {
-    const json: Record<string, any> = {
+    const json: Record<string, unknown> = {
       input: payload?.input,
       command: payload?.command,
       config: payload?.config,
@@ -1011,6 +1012,7 @@ export class RunsClient<
     const runMetadata = getRunMetadataFromResponse(response);
     if (runMetadata) payload?.onRunCreated?.(runMetadata);
 
+    // eslint-disable-next-line @typescript-eslint/no-explicit-any
     const stream: ReadableStream<{ event: any; data: any }> = (
       response.body || new ReadableStream({ start: (ctrl) => ctrl.close() })
     )
@@ -1033,7 +1035,7 @@ export class RunsClient<
     assistantId: string,
     payload?: RunsCreatePayload
   ): Promise<Run> {
-    const json: Record<string, any> = {
+    const json: Record<string, unknown> = {
       input: payload?.input,
       command: payload?.command,
       config: payload?.config,
@@ -1120,7 +1122,7 @@ export class RunsClient<
     assistantId: string,
     payload?: RunsWaitPayload
   ): Promise<ThreadState["values"]> {
-    const json: Record<string, any> = {
+    const json: Record<string, unknown> = {
       input: payload?.input,
       command: payload?.command,
       config: payload?.config,
@@ -1239,7 +1241,7 @@ export class RunsClient<
       method: "POST",
       params: {
         wait: wait ? "1" : "0",
-        action: action,
+        action,
       },
     });
   }
@@ -1287,10 +1289,12 @@ export class RunsClient<
           streamMode?: StreamMode | StreamMode[];
         }
       | AbortSignal
+    // eslint-disable-next-line @typescript-eslint/no-explicit-any
   ): AsyncGenerator<{ id?: string; event: StreamEvent; data: any }> {
     const opts =
       typeof options === "object" &&
       options != null &&
+      // eslint-disable-next-line no-instanceof/no-instanceof
       options instanceof AbortSignal
         ? { signal: options }
         : options;
@@ -1315,6 +1319,7 @@ export class RunsClient<
       )
     );
 
+    // eslint-disable-next-line @typescript-eslint/no-explicit-any
     const stream: ReadableStream<{ event: string; data: any }> = (
       response.body || new ReadableStream({ start: (ctrl) => ctrl.close() })
     )
@@ -1341,6 +1346,7 @@ export class RunsClient<
 interface APIItem {
   namespace: string[];
   key: string;
+  // eslint-disable-next-line @typescript-eslint/no-explicit-any
   value: Record<string, any>;
   created_at: string;
   updated_at: string;
@@ -1373,7 +1379,7 @@ export class StoreClient extends BaseClient {
   async putItem(
     namespace: string[],
     key: string,
-    value: Record<string, any>,
+    value: Record<string, unknown>,
     options?: {
       index?: false | string[] | null;
       ttl?: number | null;
@@ -1441,7 +1447,7 @@ export class StoreClient extends BaseClient {
       }
     });
 
-    const params: Record<string, any> = {
+    const params: Record<string, unknown> = {
       namespace: namespace.join("."),
       key,
     };
@@ -1524,7 +1530,7 @@ export class StoreClient extends BaseClient {
   async searchItems(
     namespacePrefix: string[],
     options?: {
-      filter?: Record<string, any>;
+      filter?: Record<string, unknown>;
       limit?: number;
       offset?: number;
       query?: string;
@@ -1603,7 +1609,7 @@ class UiClient extends BaseClient {
   }
 
   async getComponent(assistantId: string, agentName: string): Promise<string> {
-    return UiClient["getOrCached"](
+    return UiClient.getOrCached(
       `${this.apiUrl}-${assistantId}-${agentName}`,
       async () => {
         const response = await this.asyncCaller.fetch(

libs/sdk/src/react-ui/client.tsx

@@ -1,11 +1,10 @@
 "use client";
 
-import { useStream } from "../react/index.js";
-import type { UIMessage } from "./types.js";
-
 import * as React from "react";
 import * as ReactDOM from "react-dom";
 import * as JsxRuntime from "react/jsx-runtime";
+import type { UIMessage } from "./types.js";
+import { useStream } from "../react/index.js";
 import type { UseStream } from "../react/stream.js";
 
 const UseStreamContext = React.createContext<{
@@ -64,13 +63,15 @@ interface ComponentTarget {
 
 class ComponentStore {
   private cache: Record<string, ComponentTarget> = {};
+
   private boundCache: Record<
     string,
     {
       subscribe: (onStoreChange: () => void) => () => void;
       getSnapshot: () => ComponentTarget | undefined;
     }
   > = {};
+
   private callbacks: Record<
     string,
     ((
@@ -184,17 +185,18 @@ export function LoadExternalComponent({
   const clientComponent = components?.[message.name];
   const hasClientComponent = clientComponent != null;
 
-  const fallbackComponent = isReactNode(fallback)
-    ? fallback
-    : typeof fallback === "object" && fallback != null
-    ? fallback?.[message.name]
-    : null;
+  let fallbackComponent = null;
+  if (isReactNode(fallback)) {
+    fallbackComponent = fallback;
+  } else if (typeof fallback === "object" && fallback != null) {
+    fallbackComponent = fallback?.[message.name];
+  }
 
   const uiNamespace = namespace ?? stream.assistantId;
   const uiClient = stream.client["~ui"];
   React.useEffect(() => {
     if (hasClientComponent) return;
-    uiClient.getComponent(uiNamespace, message.name).then((html) => {
+    void uiClient.getComponent(uiNamespace, message.name).then((html) => {
       const dom = ref.current;
       if (!dom) return;
       const root = dom.shadowRoot ?? dom.attachShadow({ mode: "open" });

libs/sdk/src/react-ui/index.ts

@@ -1,4 +1,5 @@
 import { bootstrapUiContext } from "./client.js";
+
 bootstrapUiContext();
 
 export {