Skip to content

Commit 8665ae1

Browse files
authored
fix: nightly now properly gets 1.9.0 branch (#12215)
before it was attempting to pull release-notes as letters are alphanumerically after numbers when we sort -V then grab tail now we only look at branch names that follow the pattern '^release-[0-9]+\.[0-9]+\.[0-9]+$'
1 parent 8dbcbb0 commit 8665ae1

File tree

2 files changed

+9
-3
lines changed

2 files changed

+9
-3
lines changed

.github/workflows/nightly_build.yml

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -60,6 +60,7 @@ jobs:
6060
git ls-remote --heads https://github.com/${{ github.repository }} 'refs/heads/release-*' \
6161
| awk '{print $2}' \
6262
| sed 's|refs/heads/||' \
63+
| grep -E '^release-[0-9]+\.[0-9]+\.[0-9]+$' \
6364
| sort -V \
6465
| tail -n 1 > branch.txt
6566
@@ -90,6 +91,8 @@ jobs:
9091
with:
9192
ref: ${{ needs.resolve-release-branch.outputs.branch }}
9293
persist-credentials: true
94+
- name: Confirm branch
95+
run: git branch --show-current
9396
- name: "Setup Environment"
9497
uses: astral-sh/setup-uv@v6
9598
with:
@@ -99,7 +102,10 @@ jobs:
99102
prune-cache: false
100103
- name: Install the project
101104
run: uv sync
102-
105+
- name: Check script location
106+
run: |
107+
echo "PWD: $(pwd)"
108+
find . -name "pypi_nightly_tag.py"
103109
- name: Generate main nightly tag
104110
id: generate_release_tag
105111
run: |

.secrets.baseline

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -153,7 +153,7 @@
153153
"filename": ".github/workflows/nightly_build.yml",
154154
"hashed_secret": "3e26d6750975d678acb8fa35a0f69237881576b0",
155155
"is_verified": false,
156-
"line_number": 257,
156+
"line_number": 263,
157157
"is_secret": false
158158
}
159159
],
@@ -5674,5 +5674,5 @@
56745674
}
56755675
]
56765676
},
5677-
"generated_at": "2026-03-16T13:08:35Z"
5677+
"generated_at": "2026-03-17T14:09:34Z"
56785678
}

0 commit comments

Comments
 (0)