Skip to content

Commit b72aaf0

Browse files
authored
fix(client): flush on shutdown (#1474)
1 parent a139e19 commit b72aaf0

File tree

2 files changed

+3
-6
lines changed

2 files changed

+3
-6
lines changed

langfuse/_client/resource_manager.py

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -415,11 +415,7 @@ def shutdown(self) -> None:
415415
# Unregister the atexit handler first
416416
atexit.unregister(self.shutdown)
417417

418-
if self.tracer_provider is not None and not isinstance(
419-
self.tracer_provider, otel_trace_api.ProxyTracerProvider
420-
):
421-
self.tracer_provider.force_flush()
422-
418+
self.flush()
423419
self._stop_and_join_consumer_threads()
424420

425421

tests/test_datasets.py

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -50,6 +50,7 @@ def test_create_dataset_item():
5050
source_trace_id=generation.trace_id,
5151
)
5252
langfuse.create_dataset_item(
53+
input="Hello",
5354
dataset_name=name,
5455
)
5556

@@ -67,7 +68,7 @@ def test_create_dataset_item():
6768
assert dataset.items[1].source_trace_id == generation.trace_id
6869
assert dataset.items[1].dataset_name == name
6970

70-
assert dataset.items[0].input is None
71+
assert dataset.items[0].input == "Hello"
7172
assert dataset.items[0].expected_output is None
7273
assert dataset.items[0].metadata is None
7374
assert dataset.items[0].source_observation_id is None

0 commit comments

Comments
 (0)