fix(client): handle update_current_trace on non recorded spans gracefully (#1432)

hassiebp · web-flow · commit d8c624a88288 · 2025-11-11T09:37:40.000Z
diff --git a/langfuse/_client/client.py b/langfuse/_client/client.py
@@ -1664,7 +1664,7 @@ def update_current_trace(
 
         current_otel_span = self._get_current_otel_span()
 
-        if current_otel_span is not None:
+        if current_otel_span is not None and current_otel_span.is_recording():
             existing_observation_type = current_otel_span.attributes.get(  # type: ignore[attr-defined]
                 LangfuseOtelSpanAttributes.OBSERVATION_TYPE, "span"
             )

Original file line number	Diff line number	Diff line change
`@@ -1664,7 +1664,7 @@ def update_current_trace(`
`1664`	`1664`
`1665`	`1665`	`current_otel_span = self._get_current_otel_span()`
`1666`	`1666`
`1667`		`- if current_otel_span is not None:`
	`1667`	`+ if current_otel_span is not None and current_otel_span.is_recording():`
`1668`	`1668`	`existing_observation_type = current_otel_span.attributes.get( # type: ignore[attr-defined]`
`1669`	`1669`	`LangfuseOtelSpanAttributes.OBSERVATION_TYPE, "span"`
`1670`	`1670`	`)`