Skip to content

Commit 04dcfdc

Browse files
DeiuDesHommiescrazywoolagemini-code-assist[bot]
authored
fix(openai_api_compatible): add support for Zhipu AI thinking mode fo… (#2363)
* fix(openai_api_compatible): add support for Zhipu AI thinking mode format - Add top-level thinking parameter support for Zhipu API compatibility - Support both enabled and disabled thinking modes via {type: 'enabled'/'disabled'} format - Maintain backward compatibility with vLLM/SGLang chat_template_kwargs format - Bump version from 0.0.28 to 0.0.29 * Apply suggestions from code review Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com> --------- Co-authored-by: DeiuDesHommies <[email protected]> Co-authored-by: crazywoola <[email protected]> Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
1 parent 85054e7 commit 04dcfdc

File tree

2 files changed

+11
-4
lines changed

2 files changed

+11
-4
lines changed

models/openai_api_compatible/manifest.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
version: 0.0.28
1+
version: 0.0.29
22
type: plugin
33
author: "langgenius"
44
name: "openai_api_compatible"

models/openai_api_compatible/models/llm/llm.py

Lines changed: 10 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -187,9 +187,16 @@ def _invoke(
187187
enable_thinking_value = bool(user_enable_thinking)
188188

189189
if enable_thinking_value is not None:
190-
model_parameters.setdefault("chat_template_kwargs", {})["enable_thinking"] = enable_thinking_value
191-
# Add From: https://github.com/langgenius/dify-official-plugins/pull/2151
192-
model_parameters.setdefault("chat_template_kwargs", {})["thinking"] = enable_thinking_value
190+
# Support vLLM/SGLang format (chat_template_kwargs)
191+
chat_template_kwargs = model_parameters.setdefault("chat_template_kwargs", {})
192+
chat_template_kwargs["enable_thinking"] = enable_thinking_value
193+
chat_template_kwargs["thinking"] = enable_thinking_value
194+
195+
# Support Zhipu AI API format (top-level thinking parameter)
196+
# This allows compatibility with Zhipu's official API format: {"thinking": {"type": "enabled/disabled"}}
197+
model_parameters["thinking"] = {
198+
"type": "enabled" if enable_thinking_value else "disabled"
199+
}
193200

194201
# Remove thinking content from assistant messages for better performance.
195202
with suppress(Exception):

0 commit comments

Comments
 (0)