refactor: remove uuid-ossp dependency and update ID generation logic (#536)

* refactor: remove uuid-ossp dependency and update ID generation logic

* fix: condition error

Author: Yeuoly

internal/db/mysql/dialector.go

@@ -34,17 +34,18 @@ type myMigrator struct {
 func (migrator myMigrator) FullDataTypeOf(field *schema.Field) clause.Expr {
 	if field.DataType == "uuid" {
 		field.DataType = "char(36)"
-		if field.HasDefaultValue && field.DefaultValue == "uuid_generate_v4()" {
-			field.HasDefaultValue = false
-			field.DefaultValue = ""
-			var fieldsWithDefault []*schema.Field
-			for _, fieldWithDefault := range field.Schema.FieldsWithDefaultDBValue {
-				if fieldWithDefault.DBName != "id" {
-					fieldsWithDefault = append(fieldsWithDefault, fieldWithDefault)
-				}
-			}
-			field.Schema.FieldsWithDefaultDBValue = fieldsWithDefault
-		}
+		// remove default value uuid_generate_v4(), see https://github.com/langgenius/dify-plugin-daemon/issues/469
+		// if field.HasDefaultValue && field.DefaultValue == "uuid_generate_v4()" {
+		// 	field.HasDefaultValue = false
+		// 	field.DefaultValue = ""
+		// 	var fieldsWithDefault []*schema.Field
+		// 	for _, fieldWithDefault := range field.Schema.FieldsWithDefaultDBValue {
+		// 		if fieldWithDefault.DBName != "id" {
+		// 			fieldsWithDefault = append(fieldsWithDefault, fieldWithDefault)
+		// 		}
+		// 	}
+		// 	field.Schema.FieldsWithDefaultDBValue = fieldsWithDefault
+		// }
 	} else if field.DataType == "text" {
 		field.DataType = "longtext"
 	}

internal/db/pg/pg.go

@@ -69,20 +69,6 @@ func InitPluginDB(config *PGConfig) (*gorm.DB, error) {
 		return nil, err
 	}
 
-	// check if uuid-ossp extension exists
-	rows, err := pgsqlDB.Query("SELECT 1 FROM pg_extension WHERE extname = 'uuid-ossp'")
-	if err != nil {
-		return nil, err
-	}
-
-	if !rows.Next() {
-		// create the uuid-ossp extension
-		_, err = pgsqlDB.Exec("CREATE EXTENSION IF NOT EXISTS \"uuid-ossp\"")
-		if err != nil {
-			return nil, err
-		}
-	}
-
 	// configure connection pool
 	pgsqlDB.SetMaxIdleConns(config.MaxIdleConns)
 	pgsqlDB.SetMaxOpenConns(config.MaxOpenConns)

internal/types/models/base.go

@@ -8,14 +8,22 @@ import (
 )
 
 type Model struct {
-	ID        string    `gorm:"column:id;primaryKey;type:uuid;default:uuid_generate_v4()" json:"id"`
+	ID        string    `gorm:"column:id;primaryKey;type:uuid;" json:"id"`
 	CreatedAt time.Time `json:"created_at"`
 	UpdatedAt time.Time `json:"updated_at"`
 }
 
-func (m *Model) BeforeCreate(tx *gorm.DB) (err error) {
-	if tx.Dialector.Name() == "mysql" && m.ID == "" {
-		m.ID = uuid.New().String()
+// BeforeCreate sets the ID field to a new UUID v7 value before creating a new record.
+// ISSUE: https://github.com/langgenius/dify-plugin-daemon/issues/469
+//
+// to support both pgsql17 and mysql, `generate_uuid_v4` was removed from the database side.
+// as it's not compatible to some of the DB versions.
+func (m *Model) BeforeCreate(tx *gorm.DB) error {
+	uuid, err := uuid.NewV7()
+	if err != nil {
+		return err
 	}
-	return
+	m.ID = uuid.String()
+
+	return nil
 }