Skip to content

Commit 19e3d07

Browse files
committed
Update HumanInputFormDefinition.expiration_time to use unix timestamp in seconds (vibe-kanban d44e8e03)
The type of this field should be `int`.
1 parent 86d3421 commit 19e3d07

File tree

3 files changed

+4
-5
lines changed

3 files changed

+4
-5
lines changed

api/core/entities/execution_extra_content.py

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,6 @@
11
from __future__ import annotations
22

33
from collections.abc import Mapping, Sequence
4-
from datetime import datetime
54
from typing import Any, TypeAlias
65

76
from pydantic import BaseModel, ConfigDict, Field
@@ -22,7 +21,7 @@ class HumanInputFormDefinition(BaseModel):
2221
display_in_ui: bool = False
2322
form_token: str | None = None
2423
resolved_default_values: Mapping[str, Any] = Field(default_factory=dict)
25-
expiration_time: datetime
24+
expiration_time: int
2625

2726

2827
class HumanInputFormSubmissionData(BaseModel):

api/repositories/sqlalchemy_execution_extra_content_repository.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -138,7 +138,7 @@ def _map_human_input_content(
138138
display_in_ui=display_in_ui,
139139
form_token=form_token,
140140
resolved_default_values=form_definition.default_values,
141-
expiration_time=form.expiration_time,
141+
expiration_time=int(form.expiration_time.timestamp()),
142142
),
143143
)
144144

api/tests/unit_tests/repositories/test_sqlalchemy_execution_extra_content_repository.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -167,7 +167,7 @@ def test_get_by_message_ids_returns_unsubmitted_form_definition() -> None:
167167
assert domain_content.submitted is False
168168
assert domain_content.workflow_run_id == "workflow-run"
169169
assert domain_content.form_definition is not None
170-
assert domain_content.form_definition.expiration_time == form.expiration_time
170+
assert domain_content.form_definition.expiration_time == int(form.expiration_time.timestamp())
171171
assert domain_content.form_definition is not None
172172
form_definition = domain_content.form_definition
173173
assert form_definition.form_id == "form-1"
@@ -177,4 +177,4 @@ def test_get_by_message_ids_returns_unsubmitted_form_definition() -> None:
177177
assert form_definition.display_in_ui is True
178178
assert form_definition.form_token == "token-1"
179179
assert form_definition.resolved_default_values == {"name": "John"}
180-
assert form_definition.expiration_time == form.expiration_time
180+
assert form_definition.expiration_time == int(form.expiration_time.timestamp())

0 commit comments

Comments
 (0)