Skip to content

Commit aa4a987

Browse files
authored
fix: fix max_retries is hardcode (#33619)
1 parent a073d60 commit aa4a987

File tree

2 files changed

+11
-2
lines changed

2 files changed

+11
-2
lines changed

api/configs/middleware/cache/redis_config.py

Lines changed: 11 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
from pydantic import Field, NonNegativeInt, PositiveFloat, PositiveInt
1+
from pydantic import Field, NonNegativeInt, PositiveFloat, PositiveInt, field_validator
22
from pydantic_settings import BaseSettings
33

44

@@ -116,3 +116,13 @@ class RedisConfig(BaseSettings):
116116
description="Maximum connections in the Redis connection pool (unset for library default)",
117117
default=None,
118118
)
119+
120+
@field_validator("REDIS_MAX_CONNECTIONS", mode="before")
121+
@classmethod
122+
def _empty_string_to_none_for_max_conns(cls, v):
123+
"""Allow empty string in env/.env to mean 'unset' (None)."""
124+
if v is None:
125+
return None
126+
if isinstance(v, str) and v.strip() == "":
127+
return None
128+
return v

api/dify_graph/nodes/http_request/node.py

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -101,7 +101,6 @@ def _run(self) -> NodeRunResult:
101101
timeout=self._get_request_timeout(self.node_data),
102102
variable_pool=self.graph_runtime_state.variable_pool,
103103
http_request_config=self._http_request_config,
104-
max_retries=0,
105104
ssl_verify=self.node_data.ssl_verify,
106105
http_client=self._http_client,
107106
file_manager=self._file_manager,

0 commit comments

Comments
 (0)