Fixed duplicate diagnostics

Author: lannonbr

CHANGELOG.md

@@ -1,5 +1,8 @@
 # Changelog
 
+## 0.8.2 - Sep 14, 2018
+- [Hotfix] Duplicate diagnostics were showing up in problems panel. Fixed this in this patch.
+
 ## 0.8.1 - Sep 13, 2018
 - [Hotfix] Added settings to hide either of the diagnostics or error annotations
 

package-lock.json

@@ -2,7 +2,7 @@
   "name": "vscode-js-annotations",
   "displayName": "JS Parameter Annotations",
   "description": "Annotations for parameters in your JS / TS Files to mimic named parameters",
-  "version": "0.8.1",
+  "version": "0.8.2",
   "publisher": "lannonbr",
   "engines": {
     "vscode": "^1.25.0"

package.json

@@ -52,9 +52,8 @@ async function run(ctx: vscode.ExtensionContext, editor: vscode.TextEditor | und
   }
 
   // Setup variables for diagnostics when loading JS file
-  if (editor.document.languageId === "javascript") {
+  if (diagCollection === undefined && editor.document.languageId === "javascript") {
     diagCollection = vscode.languages.createDiagnosticCollection("js-annot");
-    diagnostics = [];
   }
 
   const isEnabled = vscode.workspace.getConfiguration("jsannotations").get("enabled");

src/extension.ts

@@ -40,7 +40,10 @@ suite("js annotations", () => {
     const [decArray, errDecArray] = await Extension.createDecorations(editor, editor.document.getText());
 
     assert.deepEqual(decArray.length, 1);
-    assert.deepEqual(errDecArray.length, 1);
+
+    // By Default the error decoration is hidden with the diagnostic in it's place
+    // TODO: Check for diagnostic
+    assert.deepEqual(errDecArray.length, 0);
 
     vscode.commands.executeCommand("workbench.action.closeActiveEditor");
   });