[CIR] Mark addInt as NYI due to incorrect implementation (llvm#1648)

xlauko · lanza · commit 7bf74dbec030 · 2025-08-10T21:20:03.000-07:00
The current implementation incorrectly uses `mlir::IntegerAttr::get` with the unsupported type `cir::IntType`, which is not compatible and was never tested. As discussed in PR llvm#1645, this is to be marked as NYI until a proper implementation is provided.
diff --git a/clang/lib/CIR/CodeGen/ConstantInitBuilder.h b/clang/lib/CIR/CodeGen/ConstantInitBuilder.h
@@ -187,8 +187,7 @@ class ConstantAggregateBuilderBase {
 
   /// Add an integer value of a specific type.
   void addInt(cir::IntType intTy, uint64_t value, bool isSigned = false) {
-    add(mlir::IntegerAttr::get(intTy,
-                               llvm::APInt{intTy.getWidth(), value, isSigned}));
+    llvm_unreachable("NYI");
   }
 
   /// Add a pointer of a specific type.

Original file line number	Diff line number	Diff line change
`@@ -187,8 +187,7 @@ class ConstantAggregateBuilderBase {`
`187`	`187`
`188`	`188`	`/// Add an integer value of a specific type.`
`189`	`189`	`void addInt(cir::IntType intTy, uint64_t value, bool isSigned = false) {`
`190`		`- add(mlir::IntegerAttr::get(intTy,`
`191`		`- llvm::APInt{intTy.getWidth(), value, isSigned}));`
	`190`	`+ llvm_unreachable("NYI");`
`192`	`191`	`}`
`193`	`192`
`194`	`193`	`/// Add a pointer of a specific type.`