[CIR][NFC] Fix more compiler warnings

Author: bcardosolopes

clang/lib/CIR/CodeGen/CIRGenExpr.cpp

@@ -170,7 +170,7 @@ static Address emitPointerWithAlignment(const Expr *expr,
 
         if (cgf.SanOpts.has(SanitizerKind::CFIUnrelatedCast) &&
             CE->getCastKind() == CK_BitCast) {
-          if (auto PT = expr->getType()->getAs<clang::PointerType>())
+          if (expr->getType()->getAs<clang::PointerType>())
             llvm_unreachable("NYI");
         }
 
@@ -476,7 +476,8 @@ LValue CIRGenFunction::emitCompoundLiteralLValue(const CompoundLiteralExpr *E) {
   // Block-scope compound literals are destroyed at the end of the enclosing
   // scope in C.
   if (!getLangOpts().CPlusPlus)
-    if (QualType::DestructionKind DtorKind = E->getType().isDestructedType())
+    if ([[maybe_unused]] QualType::DestructionKind DtorKind =
+            E->getType().isDestructedType())
       llvm_unreachable("NYI");
 
   return Result;
@@ -857,7 +858,8 @@ void CIRGenFunction::emitStoreThroughLValue(RValue Src, LValue Dst,
   assert(Dst.isSimple() && "only implemented simple");
 
   // There's special magic for assigning into an ARC-qualified l-value.
-  if (Qualifiers::ObjCLifetime Lifetime = Dst.getQuals().getObjCLifetime()) {
+  if ([[maybe_unused]] Qualifiers::ObjCLifetime Lifetime =
+          Dst.getQuals().getObjCLifetime()) {
     llvm_unreachable("NYI");
   }
 

clang/lib/CIR/CodeGen/CIRGenExprAgg.cpp

@@ -609,6 +609,8 @@ static bool castPreservesZero(const CastExpr *CE) {
   switch (CE->getCastKind()) {
   case CK_HLSLVectorTruncation:
   case CK_HLSLArrayRValue:
+  case CK_HLSLElementwiseCast:
+  case CK_HLSLAggregateSplatCast:
     llvm_unreachable("NYI");
     // No-ops.
   case CK_NoOp:
@@ -840,7 +842,8 @@ void AggExprEmitter::VisitCompoundLiteralExpr(CompoundLiteralExpr *E) {
   CGF.emitAggExpr(E->getInitializer(), Slot);
 
   if (Destruct)
-    if (QualType::DestructionKind DtorKind = E->getType().isDestructedType())
+    if ([[maybe_unused]] QualType::DestructionKind DtorKind =
+            E->getType().isDestructedType())
       llvm_unreachable("NYI");
 }
 
@@ -902,7 +905,7 @@ void AggExprEmitter::VisitLambdaExpr(LambdaExpr *E) {
     emitInitializationToLValue(captureInit, LV);
 
     // Push a destructor if necessary.
-    if (QualType::DestructionKind DtorKind =
+    if ([[maybe_unused]] QualType::DestructionKind DtorKind =
             CurField->getType().isDestructedType()) {
       llvm_unreachable("NYI");
     }
@@ -1688,8 +1691,7 @@ void CIRGenFunction::emitAggregateCopy(LValue Dest, LValue Src, QualType Ty,
   mlir::Attribute SizeVal = nullptr;
   if (TypeInfo.Width.isZero()) {
     // But note that getTypeInfo returns 0 for a VLA.
-    if (auto *VAT = dyn_cast_or_null<VariableArrayType>(
-            getContext().getAsArrayType(Ty))) {
+    if (isa_and_nonnull<VariableArrayType>(getContext().getAsArrayType(Ty))) {
       llvm_unreachable("VLA is NYI");
     }
   }

clang/lib/CIR/CodeGen/CIRGenExprComplex.cpp

@@ -484,6 +484,8 @@ mlir::Value ComplexExprEmitter::emitCast(CastKind CK, Expr *Op,
   case CK_MatrixCast:
   case CK_HLSLVectorTruncation:
   case CK_HLSLArrayRValue:
+  case CK_HLSLElementwiseCast:
+  case CK_HLSLAggregateSplatCast:
     llvm_unreachable("invalid cast kind for complex value");
 
   case CK_FloatingRealToComplex:

clang/lib/CIR/CodeGen/CIRGenExprConst.cpp

@@ -976,6 +976,8 @@ class ConstExprEmitter
     switch (E->getCastKind()) {
     case CK_HLSLArrayRValue:
     case CK_HLSLVectorTruncation:
+    case CK_HLSLElementwiseCast:
+    case CK_HLSLAggregateSplatCast:
     case CK_ToUnion:
       llvm_unreachable("not implemented");
 
@@ -1992,7 +1994,7 @@ mlir::Attribute ConstantEmitter::tryEmitPrivate(const APValue &Value,
     const ValueDecl *memberDecl = Value.getMemberPointerDecl();
     assert(!Value.isMemberPointerToDerivedMember() && "NYI");
 
-    if (const auto *memberFuncDecl = dyn_cast<CXXMethodDecl>(memberDecl))
+    if (isa<CXXMethodDecl>(memberDecl))
       assert(0 && "not implemented");
 
     auto cirTy = mlir::cast<cir::DataMemberType>(CGM.convertType(DestType));
@@ -2022,12 +2024,11 @@ mlir::Value CIRGenModule::emitNullConstant(QualType T, mlir::Location loc) {
   if (getTypes().isZeroInitializable(T))
     return builder.getNullValue(getTypes().convertTypeForMem(T), loc);
 
-  if (const ConstantArrayType *CAT =
-          getASTContext().getAsConstantArrayType(T)) {
+  if (getASTContext().getAsConstantArrayType(T)) {
     llvm_unreachable("NYI");
   }
 
-  if (const clang::RecordType *RT = T->getAs<clang::RecordType>())
+  if (T->getAs<clang::RecordType>())
     llvm_unreachable("NYI");
 
   assert(T->isMemberDataPointerType() &&

clang/lib/CIR/CodeGen/CIRGenExprScalar.cpp

@@ -401,7 +401,7 @@ class ScalarExprEmitter : public StmtVisitor<ScalarExprEmitter, mlir::Value> {
     mlir::Value value{};
     mlir::Value input{};
 
-    if (const AtomicType *atomicTy = type->getAs<AtomicType>()) {
+    if (type->getAs<AtomicType>()) {
       llvm_unreachable("no atomics inc/dec yet");
     } else {
       value = emitLoadOfLValue(LV, E->getExprLoc());
@@ -469,8 +469,7 @@ class ScalarExprEmitter : public StmtVisitor<ScalarExprEmitter, mlir::Value> {
       // Next most common: pointer increment.
     } else if (const PointerType *ptr = type->getAs<PointerType>()) {
       QualType type = ptr->getPointeeType();
-      if (const VariableArrayType *vla =
-              CGF.getContext().getAsVariableArrayType(type)) {
+      if (CGF.getContext().getAsVariableArrayType(type)) {
         // VLA types don't have constant size.
         llvm_unreachable("NYI");
       } else if (type->isFunctionType()) {
@@ -856,11 +855,11 @@ class ScalarExprEmitter : public StmtVisitor<ScalarExprEmitter, mlir::Value> {
   // TODO(cir): Candidate to be in a common AST helper between CIR and LLVM
   // codegen.
   QualType getPromotionType(QualType Ty) {
-    if (auto *CT = Ty->getAs<ComplexType>()) {
+    if (Ty->getAs<ComplexType>()) {
       llvm_unreachable("NYI");
     }
     if (Ty.UseExcessPrecision(CGF.getContext())) {
-      if (auto *VT = Ty->getAs<VectorType>())
+      if (Ty->getAs<VectorType>())
         llvm_unreachable("NYI");
       return CGF.getContext().FloatTy;
     }
@@ -917,7 +916,7 @@ class ScalarExprEmitter : public StmtVisitor<ScalarExprEmitter, mlir::Value> {
       }
     };
 
-    if (const MemberPointerType *MPT = LHSTy->getAs<MemberPointerType>()) {
+    if (LHSTy->getAs<MemberPointerType>()) {
       assert(E->getOpcode() == BO_EQ || E->getOpcode() == BO_NE);
       mlir::Value lhs = CGF.emitScalarExpr(E->getLHS());
       mlir::Value rhs = CGF.emitScalarExpr(E->getRHS());
@@ -992,7 +991,7 @@ class ScalarExprEmitter : public StmtVisitor<ScalarExprEmitter, mlir::Value> {
     if (SrcType->isRealFloatingType())
       return emitFloatToBoolConversion(Src, loc);
 
-    if (auto *MPT = llvm::dyn_cast<MemberPointerType>(SrcType))
+    if (llvm::isa<MemberPointerType>(SrcType))
       assert(0 && "not implemented");
 
     if (SrcType->isIntegerType())
@@ -2235,7 +2234,7 @@ LValue ScalarExprEmitter::emitCompoundAssignLValue(
   // Load/convert the LHS
   LValue LHSLV = CGF.emitLValue(E->getLHS());
 
-  if (const AtomicType *atomicTy = LHSTy->getAs<AtomicType>()) {
+  if (LHSTy->getAs<AtomicType>()) {
     assert(0 && "not implemented");
   }
 

clang/lib/CIR/CodeGen/TargetInfo.cpp

@@ -12,15 +12,6 @@
 using namespace clang;
 using namespace clang::CIRGen;
 
-static bool testIfIsVoidTy(QualType Ty) {
-  const auto *BT = Ty->getAs<BuiltinType>();
-  if (!BT)
-    return false;
-
-  BuiltinType::Kind k = BT->getKind();
-  return k == BuiltinType::Void;
-}
-
 static bool isAggregateTypeForABI(QualType T) {
   return !CIRGenFunction::hasScalarEvaluationKind(T) ||
          T->isMemberFunctionPointerType();