Merge pull request #1 from laravel-ardent/crash-getValidationRule

igorsantos07 · igorsantos07 · commit 43bc5398f2f7 · 2016-01-20T15:25:59.000-02:00
bug: getValidationRule crash on field without rule
diff --git a/src/Laravalid/Converter/Base/Converter.php b/src/Laravalid/Converter/Base/Converter.php
@@ -129,9 +129,12 @@ public function getValidationRules()
      */
     public function getValidationRule($inputName)
     {
-        return is_array($this->getValidationRules()[$inputName])?
-            $this->getValidationRules()[$inputName] :
-            explode('|', $this->getValidationRules()[$inputName]);
+        $rules = $this->getValidationRules();
+        if (isset($rules[$inputName])) {
+            return is_array($rules[$inputName])? $rules[$inputName] : explode('|', $rules[$inputName]);
+        } else {
+            return [];
+        }
     }
 
     /**
@@ -222,4 +225,4 @@ protected function getDefaultErrorMessage($laravelRule, $attribute)
 
         return ['data-msg-'.$laravelRule => $message];
     }
-}
+}

Original file line number	Diff line number	Diff line change
`@@ -129,9 +129,12 @@ public function getValidationRules()`
`129`	`129`	`*/`
`130`	`130`	`public function getValidationRule($inputName)`
`131`	`131`	`{`
`132`		`- return is_array($this->getValidationRules()[$inputName])?`
`133`		`- $this->getValidationRules()[$inputName] :`
`134`		`- explode('\|', $this->getValidationRules()[$inputName]);`
	`132`	`+ $rules = $this->getValidationRules();`
	`133`	`+ if (isset($rules[$inputName])) {`
	`134`	`+ return is_array($rules[$inputName])? $rules[$inputName] : explode('\|', $rules[$inputName]);`
	`135`	`+ } else {`
	`136`	`+ return [];`
	`137`	`+ }`
`135`	`138`	`}`
`136`	`139`
`137`	`140`	`/**`
`@@ -222,4 +225,4 @@ protected function getDefaultErrorMessage($laravelRule, $attribute)`
`222`	`225`
`223`	`226`	`return ['data-msg-'.$laravelRule => $message];`
`224`	`227`	`}`
`225`		`-}`
	`228`	`+}`