style: #16 use phpmd myself

Author: shaunthegeek

.github/workflows/laravel-6.yml

@@ -29,7 +29,9 @@ jobs:
           composer require orchestra/testbench:^v4 --dev
           ./vendor/bin/phpunit --coverage-clover coverage.xml --coverage-filter src/ tests/
       - name: Lint
-        run: ./vendor/bin/phpcs --standard=PSR12 src/ tests/
+        run: |
+          ./vendor/bin/phpcs --standard=PSR12 src/ tests/
+          ./vendor/bin/phpmd src/ text src/stubs/phpmd.xml --exclude vendor
       - name: codecov
         uses: codecov/codecov-action@v1
         with:

.github/workflows/laravel-7.yml

@@ -29,7 +29,9 @@ jobs:
           composer require orchestra/testbench:^v5 --dev
           ./vendor/bin/phpunit --coverage-clover coverage.xml --coverage-filter src/ tests/
       - name: Lint
-        run: ./vendor/bin/phpcs --standard=PSR12 src/ tests/
+        run: |
+          ./vendor/bin/phpcs --standard=PSR12 src/ tests/
+          ./vendor/bin/phpmd src/ text src/stubs/phpmd.xml --exclude vendor
       - name: codecov
         uses: codecov/codecov-action@v1
         with:

.github/workflows/laravel-8.yml

@@ -29,7 +29,9 @@ jobs:
           composer require orchestra/testbench:^v6 --dev
           ./vendor/bin/phpunit --coverage-clover coverage.xml --coverage-filter src/ tests/
       - name: Lint
-        run: ./vendor/bin/phpcs --standard=PSR12 src/ tests/
+        run: |
+          ./vendor/bin/phpcs --standard=PSR12 src/ tests/
+          ./vendor/bin/phpmd src/ text src/stubs/phpmd.xml --exclude vendor
       - name: codecov
         uses: codecov/codecov-action@v1
         with:

src/LintRouteCommand.php

@@ -29,14 +29,9 @@ class LintRouteCommand extends Command
      *
      * @return int
      */
-    public function handle()
+    public function handle(): int
     {
-        if ($this->option('file') == 'auto') {
-            Artisan::call('route:list', ['--json' => true]);
-            $json = Artisan::output();
-        } else {
-            $json = File::get($this->option('file'));
-        }
+        $json = $this->getRouteJson();
         $routes = json_decode($json, true);
         foreach ($routes as $route) {
             if ($route['uri'] == '/') {
@@ -51,10 +46,10 @@ public function handle()
             $tmp = explode('/', ltrim($route['uri'], '/'));
             foreach ($tmp as $piece) {
                 // ignore variable
-                if (preg_match('/^\{[^{]+\}$/', $piece)) {
+                if (preg_match('/^{[^{]+}$/', $piece)) {
                     continue;
                 }
-                if (!preg_match('/^[a-z0-9]+(\-[a-z0-9]+)*$/', $piece)) {
+                if (!preg_match('/^[a-z0-9]+(-[a-z0-9]+)*$/', $piece)) {
                     $this->error('user-friendly URL should follow domain rules: '
                         . 'lowercase ASCII letters, digits, and hyphens (a-z, 0–9, -)');
                     return 1;
@@ -64,4 +59,13 @@ public function handle()
 
         return 0;
     }
+
+    private function getRouteJson(): string
+    {
+        if ($this->option('file') == 'auto') {
+            Artisan::call('route:list', ['--json' => true]);
+            return Artisan::output();
+        }
+        return File::get($this->option('file'));
+    }
 }