Fixing code style

Author: claudsonm

src/Exceptions/CouldNotSendNotification.php

@@ -6,9 +6,6 @@
 
 class CouldNotSendNotification extends \Exception
 {
-    /**
-     * @return static
-     */
     public static function invalidReceiver()
     {
         return new static(
@@ -17,11 +14,6 @@ public static function invalidReceiver()
         );
     }
 
-    /**
-     * @param mixed $message
-     *
-     * @return static
-     */
     public static function invalidMessageObject($message)
     {
         $type = is_object($message) ? get_class($message) : gettype($message);

src/Sns.php

@@ -18,10 +18,11 @@ public function __construct(SnsService $snsService)
     }
 
     /**
-     * @param SnsMessage $message
-     * @param $destination
-     * @return \Aws\Result
+     * @param string $destination Phone number as described by the E.164 format.
+     *
      * @throws AwsException
+     *
+     * @return \Aws\Result
      */
     public function send(SnsMessage $message, $destination)
     {
@@ -33,7 +34,7 @@ public function send(SnsMessage $message, $destination)
         ];
 
         if (! empty($message->getSender())) {
-            $attributes +=  [
+            $attributes += [
                 'AWS.SNS.SMS.SenderID' => [
                     'DataType' => 'String',
                     'StringValue' => $message->getSender(),

src/SnsChannel.php

@@ -28,8 +28,6 @@ public function __construct(Sns $sns, Dispatcher $events)
     /**
      * Send the given notification.
      *
-     * @param  mixed                                  $notifiable
-     * @param  \Illuminate\Notifications\Notification $notification
      * @return \Aws\Result
      */
     public function send($notifiable, Notification $notification)
@@ -53,9 +51,6 @@ public function send($notifiable, Notification $notification)
     /**
      * Get the phone number to send a notification to.
      *
-     * @param  mixed                                  $notifiable
-     * @param  \Illuminate\Notifications\Notification $notification
-     * @return mixed
      * @throws CouldNotSendNotification
      */
     protected function getDestination($notifiable, Notification $notification)
@@ -70,16 +65,14 @@ protected function getDestination($notifiable, Notification $notification)
     /**
      * Try to get the phone number from some commonly used attributes for that.
      *
-     * @param  mixed $notifiable
-     * @return mixed
      * @throws CouldNotSendNotification
      */
     protected function guessDestination($notifiable)
     {
         $commonAttributes = ['phone', 'phone_number', 'full_phone'];
         foreach ($commonAttributes as $attribute) {
-            if (isset($notifiable->$attribute)) {
-                return $notifiable->$attribute;
+            if (isset($notifiable->{$attribute})) {
+                return $notifiable->{$attribute};
             }
         }
 
@@ -89,9 +82,6 @@ protected function guessDestination($notifiable)
     /**
      * Get the SNS Message object.
      *
-     * @param $notifiable
-     * @param  Notification             $notification
-     * @return SnsMessage
      * @throws CouldNotSendNotification
      */
     protected function getMessage($notifiable, Notification $notification): SnsMessage

src/SnsMessage.php

@@ -47,7 +47,6 @@ public function __construct($content)
     /**
      * Creates a new instance of the message.
      *
-     * @param array $data
      * @return SnsMessage
      */
     public static function create(array $data = [])
@@ -58,7 +57,6 @@ public static function create(array $data = [])
     /**
      * Sets the message body.
      *
-     * @param string $content
      * @return $this
      */
     public function body(string $content)
@@ -81,7 +79,6 @@ public function getBody()
     /**
      * Sets the message delivery type as promotional.
      *
-     * @param bool $active
      * @return $this
      */
     public function promotional(bool $active = true)
@@ -94,7 +91,6 @@ public function promotional(bool $active = true)
     /**
      * Sets the message delivery type as transactional.
      *
-     * @param bool $active
      * @return $this
      */
     public function transactional(bool $active = true)
@@ -117,7 +113,6 @@ public function getDeliveryType()
     /**
      * Sets the message sender identification.
      *
-     * @param string $sender
      * @return $this
      */
     public function sender(string $sender)

tests/SnsChannelTest.php

@@ -30,7 +30,7 @@ class SnsChannelTest extends TestCase
      */
     protected $channel;
 
-    public function setUp(): void
+    protected function setUp(): void
     {
         parent::setUp();
 
@@ -119,7 +119,7 @@ public function it_will_dispatch_an_event_in_case_of_an_invalid_message()
 
 class Notifiable
 {
-    public $phone_number = null;
+    public $phone_number;
 
     public function routeNotificationFor()
     {