Code review

Author: mpociot

src/CmsmsClient.php

@@ -35,7 +35,7 @@ public function __construct(GuzzleClient $client, $productToken)
     public function send(CmsmsMessage $message, $recipient)
     {
         if (is_null(Arr::get($message->toXmlArray(), 'FROM'))) {
-            $message->setOriginator(config('services.cmsms.originator'));
+            $message->originator(config('services.cmsms.originator'));
         }
 
         $response = $this->client->request('POST', static::GATEWAY_URL, [

src/CmsmsMessage.php

@@ -12,9 +12,6 @@ class CmsmsMessage
     /** @var string */
     protected $originator;
 
-    /** @var string */
-    protected $recipient;
-
     /** @var string */
     protected $reference;
 
@@ -88,7 +85,6 @@ public function toXmlArray()
         return array_filter([
             'BODY' => $this->body,
             'FROM' => $this->originator,
-            'TO' => $this->recipient,
             'REFERENCE' => $this->reference,
         ]);
     }

tests/CmsmsClientTest.php

@@ -46,6 +46,22 @@ public function it_can_send_message()
         $this->client->send($this->message, '00301234');
     }
 
+    /** @test */
+    public function it_sets_a_default_originator_if_none_is_set()
+    {
+        $message = Mockery::mock(new CmsmsMessage('Message body'));
+        $message->shouldReceive('originator')
+                ->once()
+                ->with($this->app['config']['services.cmsms.originator']);
+
+        $this->guzzle
+            ->shouldReceive('request')
+            ->once()
+            ->andReturn(new Response(200, [], ''));
+
+        $this->client->send($message, '00301234');
+    }
+
     /** @test */
     public function it_throws_exception_on_error_response()
     {