Skip to content

Commit 397a25b

Browse files
kawaxcodyphobe
authored andcommitted
Laravel 5.8 Support (#22)
* Update composer.json * fix test * fix test
1 parent 0789ff2 commit 397a25b

File tree

4 files changed

+16
-17
lines changed

4 files changed

+16
-17
lines changed

.travis.yml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,7 @@ language: php
33
php:
44
- 7.1
55
- 7.2
6+
- 7.3
67

78
env:
89
matrix:

composer.json

Lines changed: 8 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -19,19 +19,20 @@
1919
],
2020
"require": {
2121
"php": ">=7.1.2",
22+
"ext-json": "*",
2223
"guzzlehttp/guzzle": "~6.0",
23-
"illuminate/notifications": "5.6.*|5.7.*",
24-
"illuminate/support": "5.6.*|5.7.*",
25-
"illuminate/queue": "5.6.*|5.7.*",
26-
"illuminate/console": "5.6.*|5.7.*",
24+
"illuminate/notifications": "^5.6",
25+
"illuminate/support": "^5.6",
26+
"illuminate/queue": "^5.6",
27+
"illuminate/console": "^5.6",
2728
"textalk/websocket": "1.0.*"
2829
},
2930
"require-dev": {
3031
"mockery/mockery": "^1.0",
31-
"orchestra/testbench": "3.6.*|3.7.*",
32-
"laravel/framework": "5.6.*|5.7.*",
32+
"orchestra/testbench": "^3.6",
33+
"laravel/framework": "^5.6",
3334
"phpunit/phpunit": "7.*",
34-
"orchestra/database": "3.6.x-dev"
35+
"orchestra/database": "3.8.x-dev"
3536
},
3637
"autoload": {
3738
"psr-4": {

tests/BaseTest.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@
66

77
abstract class BaseTest extends \PHPUnit\Framework\TestCase
88
{
9-
public function tearDown()
9+
public function tearDown(): void
1010
{
1111
parent::tearDown();
1212

tests/SetupCommandTest.php

Lines changed: 6 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -24,9 +24,8 @@ public function it_requires_a_bot_token()
2424

2525
$this->app[Kernel::class]->registerCommand($command);
2626

27-
$returnCode = $this->artisan('discord:setup');
28-
29-
$this->assertEquals($returnCode, -1);
27+
$this->artisan('discord:setup')
28+
->assertExitCode(-1);
3029
}
3130

3231
/** @test */
@@ -41,9 +40,8 @@ public function it_tells_the_user_to_connect_the_bot_to_their_discord_server()
4140

4241
$this->app[Kernel::class]->registerCommand($command);
4342

44-
$returnCode = $this->artisan('discord:setup');
45-
46-
$this->assertEquals($returnCode, -1);
43+
$this->artisan('discord:setup')
44+
->assertExitCode(-1);
4745
}
4846

4947
/** @test */
@@ -164,8 +162,7 @@ public function it_notifies_the_user_of_a_failed_identification_attempt()
164162

165163
$this->app[Kernel::class]->registerCommand($command);
166164

167-
$returnCode = $this->artisan('discord:setup');
168-
169-
$this->assertEquals($returnCode, -1);
165+
$this->artisan('discord:setup')
166+
->assertExitCode(-1);
170167
}
171168
}

0 commit comments

Comments
 (0)