Skip to content

Commit b1c42b1

Browse files
committed
Binding fixes
1 parent 577c6b0 commit b1c42b1

File tree

3 files changed

+6
-10
lines changed

3 files changed

+6
-10
lines changed

composer.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@
1313
],
1414
"require": {
1515
"php": ">=5.5.9",
16-
"twilio/sdk": "^4.11",
16+
"twilio/sdk": "^5.4.1",
1717
"illuminate/notifications": "5.1.*|5.2.*|5.3.*",
1818
"illuminate/support": "5.1.*|5.2.*|5.3.*",
1919
"illuminate/events": "5.1.*|5.2.*|5.3.*",

src/TwilioProvider.php

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@ public function boot()
1515
$this->app->when(TwilioChannel::class)
1616
->needs(Twilio::class)
1717
->give(function () {
18-
$config = $this->app->make(TwilioConfig::class, $this->app['config']['services.twilio']);
18+
$config = $this->app->make(TwilioConfig::class);
1919
$twilio = $this->app->make(TwilioService::class, [
2020
$config->getAccountSid(),
2121
$config->getAuthToken(),
@@ -30,5 +30,8 @@ public function boot()
3030
*/
3131
public function register()
3232
{
33+
$this->app->bind(TwilioConfig::class, function () {
34+
return new TwilioConfig($this->app['config']['services.twilio']);
35+
});
3336
}
3437
}

tests/TwilioProviderTest.php

Lines changed: 1 addition & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -42,14 +42,7 @@ public function it_gives_an_instantiated_twilio_object_when_the_channel_asks_for
4242
$twilio = Mockery::mock(TwilioService::class);
4343
$config = Mockery::mock(TwilioConfig::class, $configArray);
4444

45-
$this->app->shouldReceive('offsetGet')
46-
->once()
47-
->with('config')
48-
->andReturn([
49-
'services.twilio' => $configArray
50-
]);
51-
52-
$this->app->shouldReceive('make')->with(TwilioConfig::class, $configArray)->andReturn($config);
45+
$this->app->shouldReceive('make')->with(TwilioConfig::class)->andReturn($config);
5346

5447
$config->shouldReceive('getAccountSid')->once()->andReturn($configArray['account_sid']);
5548
$config->shouldReceive('getAuthToken')->once()->andReturn($configArray['auth_token']);

0 commit comments

Comments
 (0)