Skip to content

Commit fc7791d

Browse files
committed
Removing $contentVariables from TwilioSmsMessage #154, as it clashed with TwilioContentTemplateMessage implementation
1 parent b021595 commit fc7791d

File tree

3 files changed

+3
-17
lines changed

3 files changed

+3
-17
lines changed

src/TwilioContentTemplateMessage.php

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,9 @@ public function contentSid(string $contentSid): self
2525
}
2626

2727
/**
28-
* Set the content variables.
28+
* For Content Editor/API only: Key-value pairs of Template variables and their substitution values.
29+
* content_sid parameter must also be provided.
30+
* If values are not defined in the content_variables parameter, the Template's default placeholder values are used.
2931
*
3032
* @param array $contentVariables The variables to replace in the content template (i.e. ['1' => 'John Doe'])
3133
*/

src/TwilioSmsMessage.php

Lines changed: 0 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -34,8 +34,6 @@ class TwilioSmsMessage extends TwilioMessage
3434

3535
public ?bool $sendAsMms = null;
3636

37-
public ?string $contentVariables = null;
38-
3937
public ?string $riskCheck = null;
4038

4139
/**
@@ -223,18 +221,6 @@ public function sendAsMms(bool $sendAsMms): self
223221
return $this;
224222
}
225223

226-
/**
227-
* For Content Editor/API only: Key-value pairs of Template variables and their substitution values.
228-
* content_sid parameter must also be provided.
229-
* If values are not defined in the content_variables parameter, the Template's default placeholder values are used.
230-
*/
231-
public function contentVariables(string $contentVariables): self
232-
{
233-
$this->contentVariables = $contentVariables;
234-
235-
return $this;
236-
}
237-
238224
/**
239225
* Include this parameter with a value of "disable" to skip any kind of risk check on the respective message request.
240226
* Possible values:

tests/Unit/TwilioSmsMessageTest.php

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -75,7 +75,6 @@ public function it_can_set_optional_parameters()
7575
$message->scheduleType('fixed');
7676
$message->sendAt('2021-01-01 00:00:00');
7777
$message->sendAsMms(true);
78-
$message->contentVariables('{"name": "John"}');
7978
$message->riskCheck('disable');
8079

8180
$this->assertEquals('http://example.com', $message->statusCallback);
@@ -92,7 +91,6 @@ public function it_can_set_optional_parameters()
9291
$this->assertEquals('fixed', $message->scheduleType);
9392
$this->assertEquals('2021-01-01 00:00:00', $message->sendAt);
9493
$this->assertEquals(true, $message->sendAsMms);
95-
$this->assertEquals('{"name": "John"}', $message->contentVariables);
9694
$this->assertEquals('disable', $message->riskCheck);
9795
}
9896
}

0 commit comments

Comments
 (0)