Revert the TwitterNotification implementation

Author: otsch

CHANGELOG.md

@@ -6,10 +6,6 @@ All notable changes to the `Twitter notification channel` will be documented in
 ### Added
 - Abstract parent class `TwitterMessage` for
   `TwitterStatusUpdate` and `TwitterDirectMessage`.
-- Abstract parent class `TwitterNotification` having
-  the default implementation of `via` and defining 
-  the `toTwitter` method that needs to return an
-  instance of the new `TwitterMessage` class.
 
 ### Changed
 - Add a lot of missing argument and return types.

README.md

@@ -72,13 +72,24 @@ To use this package, you need to create a notification class, like `NewsWasPubli
 ```php
 <?php
 
+use Illuminate\Notifications\Notification;
 use NotificationChannels\Twitter\TwitterChannel;
 use NotificationChannels\Twitter\TwitterMessage;
-use NotificationChannels\Twitter\TwitterNotification;
 use NotificationChannels\Twitter\TwitterStatusUpdate;
 
-class NewsWasPublished extends TwitterNotification
+class NewsWasPublished extends Notification
 {
+    /**
+     * Get the notification's delivery channels.
+     *
+     * @param  mixed  $notifiable
+     * @return array
+     */
+    public function via($notifiable)
+    {
+        return [TwitterChannel::class];
+    }
+
     public function toTwitter(mixed $notifiable): TwitterMessage
     {
         return new TwitterStatusUpdate('Laravel notifications are awesome!');
@@ -88,8 +99,6 @@ class NewsWasPublished extends TwitterNotification
 
 Take a closer look at the `toTwitter` method. Here we define what kind of Twitter message we want to trigger. In this case, it is a status update message, which is just a new message in your timeline.
 
-It's recommended to also implement the `TwitterNotification` interface that requires the `toTwitter` method and also that it returns an instance of `TwitterMessage`.
-
 ````php
 public function toTwitter(mixed $notifiable): TwitterMessage
 {

src/TwitterChannel.php

@@ -3,6 +3,7 @@
 namespace NotificationChannels\Twitter;
 
 use Abraham\TwitterOAuth\TwitterOAuth;
+use Illuminate\Notifications\Notification;
 use NotificationChannels\Twitter\Exceptions\CouldNotSendNotification;
 
 class TwitterChannel
@@ -18,7 +19,7 @@ public function __construct(protected TwitterOAuth $twitter)
      *
      * @throws CouldNotSendNotification
      */
-    public function send($notifiable, TwitterNotification $notification): array|object
+    public function send($notifiable, Notification $notification): array|object
     {
         $this->changeTwitterSettingsIfNeeded($notifiable);
 

src/TwitterNotification.php

@@ -3,11 +3,11 @@
 namespace NotificationChannels\Twitter\Test;
 
 use Abraham\TwitterOAuth\TwitterOAuth;
+use Illuminate\Notifications\Notification;
 use Mockery;
 use NotificationChannels\Twitter\Exceptions\CouldNotSendNotification;
 use NotificationChannels\Twitter\TwitterChannel;
 use NotificationChannels\Twitter\TwitterMessage;
-use NotificationChannels\Twitter\TwitterNotification;
 use NotificationChannels\Twitter\TwitterStatusUpdate;
 use stdClass;
 
@@ -122,12 +122,9 @@ public function routeNotificationForTwitter()
     }
 }
 
-class TestNotification extends TwitterNotification
+class TestNotification extends Notification
 {
     /**
-     * @param  mixed  $notifiable
-     * @return TwitterStatusUpdate
-     *
      * @throws CouldNotSendNotification
      */
     public function toTwitter(mixed $notifiable): TwitterMessage
@@ -136,12 +133,9 @@ public function toTwitter(mixed $notifiable): TwitterMessage
     }
 }
 
-class TestNotificationWithImage extends TwitterNotification
+class TestNotificationWithImage extends Notification
 {
     /**
-     * @param  mixed  $notifiable
-     * @return TwitterStatusUpdate
-     *
      * @throws CouldNotSendNotification
      */
     public function toTwitter(mixed $notifiable): TwitterMessage