code review: nitpicks

Author: freekmurze

src/Exceptions/CouldNotSendNotification.php

@@ -6,8 +6,7 @@ class CouldNotSendNotification extends \Exception
 {
     public static function serviceRespondedWithAnError($response)
     {
-        return new static("Couldn't post Twitter status. Error: " . $response->errors[0]->code . ' Message: ' .
-        $response->errors[0]->message);
+        return new static("Couldn't post Twitter status. Error: {$response->errors[0]->code} Message: {$response->errors[0]->message}");
     }
 
 }

src/Twitter.php

@@ -7,33 +7,16 @@
 
 class Twitter
 {
-
-    /** @var mixed @var string */
-    protected $consumer_key;
-
-    /** @var mixed @var string */
-    protected $consumer_secret;
-
-    /** @var mixed @var string */
-    protected $access_token;
-
-    /** @var mixed @var string */
-    protected $access_secret;
-
-    /** @var TwitterOAuth */
+    /** @var \Abraham\TwitterOAuth\TwitterOAuth */
     public $connection;
 
     public function __construct(array $config)
     {
-        $this->consumer_key = $config['consumer_key'];
-        $this->consumer_secret = $config['consumer_secret'];
-        $this->access_token = $config['access_token'];
-        $this->access_secret = $config['access_secret'];
         $this->connection = new TwitterOAuth(
-            $this->consumer_key,
-            $this->consumer_secret,
-            $this->access_token,
-            $this->access_secret
+            $config['consumer_key'],
+            $config['consumer_secret'],
+            $config['access_token'],
+            $config['access_secret']
         );
     }
 }

src/TwitterChannel.php

@@ -8,13 +8,11 @@
 
 class TwitterChannel
 {
-
     /** @var Client */
     protected $client;
-    /**
-     * @var Twitter
-     */
-    private $twitter;
+
+    /** @var Twitter */
+    protected $twitter;
 
     /**
      * @param Client $client
@@ -31,6 +29,7 @@ public function __construct(Client $client, Twitter $twitter)
      *
      * @param mixed $notifiable
      * @param \Illuminate\Notifications\Notification $notification
+     *
      * @throws CouldNotSendNotification
      */
     public function send($notifiable, Notification $notification)

src/TwitterMessage.php

@@ -5,12 +5,20 @@
 class TwitterMessage
 {
 
-    /** @var string @var string */
+    /**  @var string */
     protected $content;
 
     /**
-     * Message constructor.
+     * @param string $content
      *
+     * @return static
+     */
+    public static function create($content = '')
+    {
+        return new static($content);
+    }
+
+    /*
      * @param string $content
      */
     public function __construct($content = '')
@@ -20,9 +28,11 @@ public function __construct($content = '')
 
     /**
      * Get Twitter message content
+     *
      * @return string
      */
-    public function getContent() {
+    public function getContent()
+    {
         return $this->content;
     }
 

tests/TwitterMessageTest.php

@@ -6,8 +6,16 @@
 
 class TwitterMessageTest extends \PHPUnit_Framework_TestCase
 {
+    /** @var TwitterMessage */
     protected $message;
 
+    /** @test */
+    public function it_provides_a_factory_method()
+    {
+        $message = TwitterMessage::create('myMessage');
+
+        $this->assertEquals('myMessage', $message->getContent());
+    }
 
     /** @test */
     public function it_accepts_a_message_when_constructing_a_message()