Merge pull request #27 from christophrumpel/master

Remove php56 from tests, sensio lab fixes

Author: Christoph Rumpel

.gitignore

@@ -2,4 +2,3 @@
 build
 composer.phar
 composer.lock
-.idea

.travis.yml

@@ -1,7 +1,6 @@
 language: php
 
 php:
-  - 5.6
   - 7.0
   - 7.1
 

CHANGELOG.md

@@ -1,4 +1,4 @@
-# Twitter notification channel for Laravel 5.4
+# Twitter notification channel for Laravel 5.3+
 
 [![Latest Version on Packagist](https://img.shields.io/packagist/v/laravel-notification-channels/twitter.svg?style=flat-square)](https://packagist.org/packages/laravel-notification-channels/twitter)
 [![Software License](https://img.shields.io/badge/license-MIT-brightgreen.svg?style=flat-square)](LICENSE.md)

CONTRIBUTING.md

@@ -8,7 +8,6 @@
 
 class TwitterChannel
 {
-
     /** @var TwitterOAuth */
     protected $twitter;
 
@@ -38,7 +37,7 @@ public function send($notifiable, Notification $notification)
         if (is_a($twitterMessage, TwitterStatusUpdate::class) && $twitterMessage->getImages()) {
             $this->twitter->setTimeouts(10, 15);
 
-            $twitterMessage->imageIds = collect($twitterMessage->getImages())->map(function ($image) {
+            $twitterMessage->imageIds = collect($twitterMessage->getImages())->map(function (TwitterImage $image) {
                 $media = $this->twitter->upload('media/upload', ['media' => $image->getPath()]);
 
                 return $media->media_id_string;
@@ -53,13 +52,12 @@ public function send($notifiable, Notification $notification)
     }
 
     /**
-     * Use per user settings instead of default ones
+     * Use per user settings instead of default ones.
      * @param $twitterSettings
      */
     private function switchSettings($twitterSettings)
     {
         $this->twitter = new TwitterOAuth($twitterSettings[0], $twitterSettings[1], $twitterSettings[2],
             $twitterSettings[3]);
     }
-
 }

README.md

@@ -4,11 +4,9 @@
 
 use Kylewm\Brevity\Brevity;
 use NotificationChannels\Twitter\Exceptions\CouldNotSendNotification;
-use NotificationChannels\Twitter\TwitterImage;
 
 class TwitterStatusUpdate
 {
-
     /** @var string */
     protected $content;
 
@@ -100,12 +98,12 @@ public function getRequestBody()
     }
 
     /**
-     * Check if the message length is too long
+     * Check if the message length is too long.
      * @param $content
      * @param $brevity
      * @return int
      */
-    private function messageIsTooLong($content, $brevity)
+    private function messageIsTooLong($content, Brevity $brevity)
     {
         $tweetLength = $brevity->tweetLength($content);
         $exceededLength = $tweetLength - 140;