Prevent log expired subscription

oele-dev · oele-dev · commit 232e697279f3 · 2020-06-19T12:24:06.000-05:00
diff --git a/src/ReportHandler.php b/src/ReportHandler.php
@@ -20,10 +20,11 @@ public function handleReport($report, $subscription, $message)
             return;
         }
 
-        Log::warning("Notification failed to sent for subscription {$subscription->endpoint}: {$report->getReason()}");
-
         if ($report->isSubscriptionExpired()) {
             $subscription->delete();
+
+            return;
         }
+        Log::warning("Notification failed to sent for subscription {$subscription->endpoint}: {$report->getReason()}");
     }
 }

Original file line number	Diff line number	Diff line change
`@@ -20,10 +20,11 @@ public function handleReport($report, $subscription, $message)`
`20`	`20`	`return;`
`21`	`21`	`}`
`22`	`22`
`23`		`- Log::warning("Notification failed to sent for subscription {$subscription->endpoint}: {$report->getReason()}");`
`24`		`-`
`25`	`23`	`if ($report->isSubscriptionExpired()) {`
`26`	`24`	`$subscription->delete();`
	`25`	`+`
	`26`	`+ return;`
`27`	`27`	`}`
	`28`	`+ Log::warning("Notification failed to sent for subscription {$subscription->endpoint}: {$report->getReason()}");`
`28`	`29`	`}`
`29`	`30`	`}`