Merge pull request #40 from laravel-shift/sequential-migrations

Sequence migration timestamp by models

Author: jasonmccreary

src/Generators/MigrationGenerator.php

@@ -4,6 +4,7 @@
 
 use Blueprint\Contracts\Generator;
 use Blueprint\Models\Model;
+use Carbon\Carbon;
 use Illuminate\Support\Str;
 
 class MigrationGenerator implements Generator
@@ -24,9 +25,11 @@ public function output(array $tree): array
 
         $stub = $this->files->get(STUBS_PATH . '/migration.stub');
 
+        $sequential_timestamp = \Carbon\Carbon::now()->subSeconds(count($tree['models']));
+
         /** @var \Blueprint\Models\Model $model */
         foreach ($tree['models'] as $model) {
-            $path = $this->getPath($model);
+            $path = $this->getPath($model, $sequential_timestamp->addSecond());
             $this->files->put(
                 $path,
                 $this->populateStub($stub, $model)
@@ -99,8 +102,8 @@ protected function getClassName(Model $model)
         return 'Create' . Str::studly($model->tableName()) . 'Table';
     }
 
-    protected function getPath(Model $model)
+    protected function getPath(Model $model, Carbon $timestamp)
     {
-        return 'database/migrations/' . \Carbon\Carbon::now()->format('Y_m_d_His') . '_create_' . $model->tableName() . '_table.php';
+        return 'database/migrations/' . $timestamp->format('Y_m_d_His') . '_create_' . $model->tableName() . '_table.php';
     }
 }

tests/Feature/Generator/MigrationGeneratorTest.php

@@ -69,6 +69,32 @@ public function output_writes_migration_for_model_tree($definition, $path, $migr
         $this->assertEquals(['created' => [$timestamp_path]], $this->subject->output($tree));
     }
 
+    /**
+     * @test
+     */
+    public function output_uses_past_timestamp_for_multiple_migrations()
+    {
+        $this->files->expects('get')
+            ->with('stubs/migration.stub')
+            ->andReturn(file_get_contents('stubs/migration.stub'));
+
+        $now = Carbon::now();
+        Carbon::setTestNow($now);
+
+        $post_path = str_replace('timestamp', $now->copy()->subSecond()->format('Y_m_d_His'), 'database/migrations/timestamp_create_posts_table.php');
+        $comment_path = str_replace('timestamp', $now->format('Y_m_d_His'), 'database/migrations/timestamp_create_comments_table.php');
+
+        $this->files->expects('put')
+            ->with($post_path, $this->fixture('migrations/posts.php'));
+        $this->files->expects('put')
+            ->with($comment_path, $this->fixture('migrations/comments.php'));
+
+        $tokens = $this->blueprint->parse($this->fixture('definitions/multiple-models.bp'));
+        $tree = $this->blueprint->analyze($tokens);
+
+        $this->assertEquals(['created' => [$post_path, $comment_path]], $this->subject->output($tree));
+    }
+
     public function modelTreeDataProvider()
     {
         return [

tests/fixtures/definitions/multiple-models.bp

@@ -0,0 +1,6 @@
+models:
+  Post:
+    title: string
+
+  Comment:
+    content: text

tests/fixtures/migrations/comments.php

@@ -0,0 +1,32 @@
+<?php
+
+use Illuminate\Database\Migrations\Migration;
+use Illuminate\Database\Schema\Blueprint;
+use Illuminate\Support\Facades\Schema;
+
+class CreateCommentsTable extends Migration
+{
+    /**
+     * Run the migrations.
+     *
+     * @return void
+     */
+    public function up()
+    {
+        Schema::create('comments', function (Blueprint $table) {
+            $table->increments('id');
+            $table->text('content');
+            $table->timestamps();
+        });
+    }
+
+    /**
+     * Reverse the migrations.
+     *
+     * @return void
+     */
+    public function down()
+    {
+        Schema::dropIfExists('comments');
+    }
+}

tests/fixtures/migrations/posts.php

@@ -0,0 +1,32 @@
+<?php
+
+use Illuminate\Database\Migrations\Migration;
+use Illuminate\Database\Schema\Blueprint;
+use Illuminate\Support\Facades\Schema;
+
+class CreatePostsTable extends Migration
+{
+    /**
+     * Run the migrations.
+     *
+     * @return void
+     */
+    public function up()
+    {
+        Schema::create('posts', function (Blueprint $table) {
+            $table->increments('id');
+            $table->string('title');
+            $table->timestamps();
+        });
+    }
+
+    /**
+     * Reverse the migrations.
+     *
+     * @return void
+     */
+    public function down()
+    {
+        Schema::dropIfExists('posts');
+    }
+}