Backfill test for pivot migration

Author: jasonmccreary

src/Generators/MigrationGenerator.php

@@ -18,19 +18,17 @@ class MigrationGenerator implements Generator
     ];
 
     const UNSIGNABLE_TYPES = [
-      'bigInteger',
-      'decimal',
-      'integer',
-      'mediumInteger',
-      'smallInteger',
-      'tinyInteger',
+        'bigInteger',
+        'decimal',
+        'integer',
+        'mediumInteger',
+        'smallInteger',
+        'tinyInteger',
     ];
 
     /** @var \Illuminate\Contracts\Filesystem\Filesystem */
     private $files;
 
-    private $pivotTables = [];
-
     public function __construct($files)
     {
         $this->files = $files;
@@ -39,6 +37,7 @@ public function __construct($files)
     public function output(array $tree): array
     {
         $output = [];
+        $created_pivot_tables = [];
 
         $stub = $this->files->stub('migration.stub');
 
@@ -51,24 +50,18 @@ public function output(array $tree): array
 
             $output['created'][] = $path;
 
-            if (!empty($modelPivots = $model->pivotTables())) {
-                foreach ($modelPivots as $pivotSegments) {
+            if (!empty($model->pivotTables())) {
+                foreach ($model->pivotTables() as $pivotSegments) {
                     $pivotTable = $this->getPivotTableName($pivotSegments);
-                    if (!isset($this->pivotTables[$pivotTable])) {
-                        $this->pivotTables[$pivotTable] = [
-                            'tableName' => $pivotTable,
-                            'segments' => $pivotSegments
-                        ];
+                    if (isset($created_pivot_tables[$pivotTable])) {
+                        continue;
                     }
-                }
-            }
-        }
 
-        if (!empty($this->pivotTables)) {
-            foreach ($this->pivotTables as $pivotTable) {
-                $path = $this->getPivotTablePath($pivotTable['tableName'], $sequential_timestamp->addSecond());
-                $this->files->put($path, $this->populatePivotStub($stub, $pivotTable['segments']));
-                $output['created'][] = $path;
+                    $path = $this->getPivotTablePath($pivotTable, $sequential_timestamp);
+                    $this->files->put($path, $this->populatePivotStub($stub, $pivotSegments));
+                    $created_pivot_tables[] = $pivotTable;
+                    $output['created'][] = $path;
+                }
             }
         }
 

tests/Feature/Generator/MigrationGeneratorTest.php

@@ -99,7 +99,7 @@ public function output_uses_past_timestamp_for_multiple_migrations()
     /**
      * @test
      */
-    public function output_uses_big_increments_for_id_column()
+    public function output_uses_proper_data_type_for_id_column()
     {
         $app = \Mockery::mock();
         $app->expects('version')
@@ -125,6 +125,39 @@ public function output_uses_big_increments_for_id_column()
         $this->assertEquals(['created' => [$timestamp_path]], $this->subject->output($tree));
     }
 
+    /**
+     * @test
+     */
+    public function output_also_creates_pivot_table_migration()
+    {
+        $app = \Mockery::mock();
+        $app->expects('version')
+            ->withNoArgs()
+            ->andReturn('6.0.0');
+        App::swap($app);
+
+        $this->files->expects('stub')
+            ->with('migration.stub')
+            ->andReturn(file_get_contents('stubs/migration.stub'));
+
+        $now = Carbon::now();
+        Carbon::setTestNow($now);
+
+        $model_migration = str_replace('timestamp', $now->format('Y_m_d_His'), 'database/migrations/timestamp_create_journeys_table.php');
+        $pivot_migration = str_replace('timestamp', $now->format('Y_m_d_His'), 'database/migrations/timestamp_create_diary_journey_table.php');
+
+        $this->files->expects('put')
+            ->with($model_migration, $this->fixture('migrations/belongs-to-many.php'));
+
+        $this->files->expects('put')
+            ->with($pivot_migration, $this->fixture('migrations/belongs-to-many-pivot.php'));
+
+        $tokens = $this->blueprint->parse($this->fixture('definitions/belongs-to-many.bp'));
+        $tree = $this->blueprint->analyze($tokens);
+
+        $this->assertEquals(['created' => [$model_migration, $pivot_migration]], $this->subject->output($tree));
+    }
+
     public function modelTreeDataProvider()
     {
         return [

tests/fixtures/definitions/belongs-to-many.bp

@@ -0,0 +1,5 @@
+models:
+  Journey:
+    name: string
+    relationships:
+      belongstoMany: Diary

tests/fixtures/migrations/belongs-to-many-pivot.php

@@ -0,0 +1,31 @@
+<?php
+
+use Illuminate\Database\Migrations\Migration;
+use Illuminate\Database\Schema\Blueprint;
+use Illuminate\Support\Facades\Schema;
+
+class CreateDiaryJourneyTable extends Migration
+{
+    /**
+     * Run the migrations.
+     *
+     * @return void
+     */
+    public function up()
+    {
+        Schema::create('diary_journey', function (Blueprint $table) {
+            $table->unsignedBigInteger('journey_id');
+            $table->unsignedBigInteger('diary_id');
+        });
+    }
+
+    /**
+     * Reverse the migrations.
+     *
+     * @return void
+     */
+    public function down()
+    {
+        Schema::dropIfExists('diary_journey');
+    }
+}

tests/fixtures/migrations/belongs-to-many.php

@@ -0,0 +1,32 @@
+<?php
+
+use Illuminate\Database\Migrations\Migration;
+use Illuminate\Database\Schema\Blueprint;
+use Illuminate\Support\Facades\Schema;
+
+class CreateJourneysTable extends Migration
+{
+    /**
+     * Run the migrations.
+     *
+     * @return void
+     */
+    public function up()
+    {
+        Schema::create('journeys', function (Blueprint $table) {
+            $table->bigIncrements('id');
+            $table->string('name');
+            $table->timestamps();
+        });
+    }
+
+    /**
+     * Reverse the migrations.
+     *
+     * @return void
+     */
+    public function down()
+    {
+        Schema::dropIfExists('journeys');
+    }
+}