Disable id column (#111)

Author: ttomdewit

src/Generators/MigrationGenerator.php

@@ -69,7 +69,7 @@ protected function buildDefinition(Model $model)
         /** @var \Blueprint\Models\Column $column */
         foreach ($model->columns() as $column) {
             $dataType = $column->dataType();
-            if ($column->name() === 'id' && $dataType === 'id') {
+            if ($column->name() === 'id' && $dataType === 'id' && $model->usesPrimaryKey()) {
                 $dataType = 'bigIncrements';
             } elseif ($dataType === 'id') {
                 $dataType = 'unsignedBigInteger';

src/Lexers/ModelLexer.php

@@ -117,6 +117,12 @@ private function buildModel(string $name, array $columns)
     {
         $model = new Model($name);
 
+        if (isset($columns['id'])) {
+            if ($columns['id'] === false) {
+                $model->disablePrimaryKey();
+            }
+        }
+
         if (isset($columns['timestamps'])) {
             if ($columns['timestamps'] === false) {
                 $model->disableTimestamps();

src/Models/Model.php

@@ -8,6 +8,7 @@ class Model
 {
     private $name;
     private $namespace;
+    private $primaryKey = 'id';
     private $timestamps = 'timestamps';
     private $softDeletes = false;
     private $columns = [];
@@ -73,7 +74,17 @@ public function relationships(): array
 
     public function primaryKey()
     {
-        return 'id';
+        return $this->primaryKey;
+    }
+
+    public function usesPrimaryKey()
+    {
+        return $this->primaryKey !== false;
+    }
+
+    public function disablePrimaryKey()
+    {
+        $this->primaryKey = false;
     }
 
     public function tableName()

tests/Feature/BlueprintTest.php

@@ -95,6 +95,29 @@ public function it_parses_shorthands()
         ], $this->subject->parse($blueprint));
     }
 
+    /**
+     * @test
+     */
+    public function it_parses_shorthands_that_disables_id()
+    {
+        $blueprint = $this->fixture('definitions/without-id.bp');
+
+        $this->assertEquals([
+            'models' => [
+                'Name' => [
+                    'softdeletes' => 'softDeletes',
+                    'id' => false,
+                    'timestamps' => 'timestamps',
+                ],
+            ],
+            'controllers' => [
+                'Context' => [
+                    'resource' => 'all'
+                ]
+            ]
+        ], $this->subject->parse($blueprint));
+    }
+
     /**
      * @test
      */

tests/Feature/Lexers/ModelLexerTest.php

@@ -131,6 +131,30 @@ public function it_defaults_the_id_column()
         $this->assertEquals(['nullable'], $columns['title']->modifiers());
     }
 
+    /**
+     * @test
+     */
+    public function it_disables_primary_keys()
+    {
+        $tokens = [
+            'models' => [
+                'Model' => [
+                    'id' => false,
+                ]
+            ],
+        ];
+
+        $actual = $this->subject->analyze($tokens);
+
+        $this->assertIsArray($actual['models']);
+        $this->assertCount(1, $actual['models']);
+
+        $model = $actual['models']['Model'];
+
+        $this->assertEquals('Model', $model->name());
+        $this->assertFalse($model->usesPrimaryKey());
+    }
+
     /**
      * @test
      */

tests/fixtures/definitions/without-id.bp

@@ -0,0 +1,9 @@
+models:
+  Name:
+    softDeletes
+    id: false
+    timestamps
+
+controllers:
+  Context:
+    resource