Use morphs instead of manually building columns (#627)

Author: Brian Faust

src/Generators/MigrationGenerator.php

@@ -270,8 +270,7 @@ protected function buildDefinition(Model $model)
 
         if (array_key_exists('morphTo', $relationships)) {
             foreach ($relationships['morphTo'] as $morphTo) {
-                $definition .= self::INDENT . sprintf('$table->unsignedBigInteger(\'%s\');', Str::lower($morphTo . '_id')) . PHP_EOL;
-                $definition .= self::INDENT . sprintf('$table->string(\'%s\');', Str::lower($morphTo . '_type')) . PHP_EOL;
+                $definition .= self::INDENT . sprintf('$table->morphs(\'%s\');', Str::lower($morphTo)) . PHP_EOL;
             }
         }
 
@@ -332,8 +331,7 @@ protected function buildPolyTableDefinition(string $parentTable)
             $definition .= self::INDENT . '$table->foreignId(\'' . $foreign . '\');' . PHP_EOL;
         }
 
-        $definition .= self::INDENT . sprintf('$table->unsignedBigInteger(\'%s\');', Str::lower(Str::singular($parentTable) . 'able' . '_id')) . PHP_EOL;
-        $definition .= self::INDENT . sprintf('$table->string(\'%s\');', Str::lower(Str::singular($parentTable) . 'able' . '_type')) . PHP_EOL;
+        $definition .= self::INDENT . sprintf('$table->morphs(\'%s\');', Str::lower(Str::singular($parentTable) . 'able')) . PHP_EOL;
 
         return trim($definition);
     }

tests/fixtures/migrations/morphed-by-many-intermediate.php

@@ -13,8 +13,7 @@ public function up(): void
     {
         Schema::create('tagables', function (Blueprint $table) {
             $table->foreignId('tag_id');
-            $table->unsignedBigInteger('tagable_id');
-            $table->string('tagable_type');
+            $table->morphs('tagable');
         });
     }
 

tests/fixtures/migrations/polymorphic_relationships_images_table.php

@@ -14,8 +14,7 @@ public function up(): void
         Schema::create('images', function (Blueprint $table) {
             $table->id();
             $table->string('url', 400);
-            $table->unsignedBigInteger('imageable_id');
-            $table->string('imageable_type');
+            $table->morphs('imageable');
             $table->timestamps();
         });
     }

tests/fixtures/migrations/polymorphic_relationships_images_table_multiple_morphto.php

@@ -14,10 +14,8 @@ public function up(): void
         Schema::create('images', function (Blueprint $table) {
             $table->id();
             $table->string('url', 400);
-            $table->unsignedBigInteger('imageable_id');
-            $table->string('imageable_type');
-            $table->unsignedBigInteger('tagable_id');
-            $table->string('tagable_type');
+            $table->morphs('imageable');
+            $table->morphs('tagable');
             $table->timestamps();
         });
     }