Add support for route generation using FQCN (#323)

Author: spaceemotion

config/blueprint.php

@@ -102,4 +102,18 @@
 
     'use_guarded' => false,
 
+    /*
+    |--------------------------------------------------------------------------
+    | Generate FQCN Routes
+    |--------------------------------------------------------------------------
+    |
+    | By default, Blueprint follows the Laravel convention of the controller
+    | namespace matches the namespace set within the RouteServiceProvider.
+    | However, you may configure Blueprint to generate routes using a
+    | "tuple syntax" in cases where you may not use this property
+    | or wish to improve static analysis.
+    |
+    */
+    'generate_fqcn_route' => false,
+
 ];

src/Generators/RouteGenerator.php

@@ -52,14 +52,19 @@ protected function buildRoutes(Controller $controller)
         $routes = '';
         $methods = array_keys($controller->methods());
 
-        $className = str_replace('App\Http\Controllers\\', '', $controller->fullyQualifiedClassName());
+        $useTuples = config('blueprint.generate_fqcn_route');
+
+        $className = $useTuples
+            ? $controller->fullyQualifiedClassName() . '::class'
+            : '\'' . str_replace('App\Http\Controllers\\', '', $controller->fullyQualifiedClassName()) . '\'';
+
         $slug = Str::kebab($controller->prefix());
 
         $resource_methods = array_intersect($methods, Controller::$resourceMethods);
         if (count($resource_methods)) {
             $routes .= $controller->isApiResource()
-                ? sprintf("Route::apiResource('%s', '%s')", $slug, $className)
-                : sprintf("Route::resource('%s', '%s')", $slug, $className);
+                ? sprintf("Route::apiResource('%s', %s)", $slug, $className)
+                : sprintf("Route::resource('%s', %s)", $slug, $className);
 
             $missing_methods = $controller->isApiResource()
                 ? array_diff(Controller::$apiResourceMethods, $resource_methods)
@@ -78,7 +83,14 @@ protected function buildRoutes(Controller $controller)
 
         $methods = array_diff($methods, Controller::$resourceMethods);
         foreach ($methods as $method) {
-            $routes .= sprintf("Route::get('%s/%s', '%s@%s');", $slug, Str::kebab($method), $className, $method);
+            if ($useTuples) {
+                $action = "[{$className}, '{$method}']";
+            } else {
+                $classNameNoQuotes = trim($className, '\'');
+                $action = "'{$classNameNoQuotes}@{$method}'";
+            }
+
+            $routes .= sprintf("Route::get('%s/%s', %s);", $slug, Str::kebab($method), $action);
             $routes .= PHP_EOL;
         }
 

tests/Feature/Generator/RouteGeneratorTest.php

@@ -88,6 +88,22 @@ public function output_generates_routes_for_mixed_resources()
         $this->assertEquals(['updated' => ['routes/api.php', 'routes/web.php']], $this->subject->output($tree));
     }
 
+    /**
+     * @test
+     */
+    public function output_generates_routes_using_tuples()
+    {
+        config(['blueprint.generate_fqcn_route' => true]);
+
+        $this->files->expects('append')
+            ->with('routes/web.php', $this->fixture('routes/routes-tuples.php'));
+
+        $tokens = $this->blueprint->parse($this->fixture('drafts/routes-tuples.yaml'));
+        $tree = $this->blueprint->analyze($tokens);
+
+        $this->subject->output($tree);
+    }
+
     public function controllerTreeDataProvider()
     {
         return [

tests/fixtures/drafts/routes-tuples.yaml

@@ -0,0 +1,10 @@
+models:
+  Foo:
+    name: string
+
+controllers:
+  Foo:
+    resource
+  Some:
+    whatever:
+      redirect: some.index

tests/fixtures/routes/routes-tuples.php

@@ -0,0 +1,5 @@
+
+
+Route::resource('foo', App\Http\Controllers\FooController::class);
+
+Route::get('some/whatever', [App\Http\Controllers\SomeController::class, 'whatever']);