Skip to content

Commit 87a3228

Browse files
authored
Don't require nullable fields for model validation shorthand (#259)
1 parent 7db7fba commit 87a3228

File tree

3 files changed

+7
-3
lines changed

3 files changed

+7
-3
lines changed

src/Translators/Rules.php

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,11 @@ class Rules
99
{
1010
public static function fromColumn(string $context, Column $column)
1111
{
12-
$rules = ['required'];
12+
$rules = [];
13+
14+
if (!in_array('nullable', $column->modifiers())) {
15+
array_push($rules, 'required');
16+
}
1317

1418
// hack for tests...
1519
if (in_array($column->dataType(), ['string', 'char', 'text', 'longText'])) {

tests/fixtures/form-requests/certificate-store.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,7 @@ public function rules()
2929
'reference' => 'required|string',
3030
'document' => 'required|string',
3131
'expiry_date' => 'required|date',
32-
'remarks' => 'required|string',
32+
'remarks' => 'string',
3333
];
3434
}
3535
}

tests/fixtures/form-requests/certificate-update.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,7 @@ public function rules()
2929
'reference' => 'required|string',
3030
'document' => 'required|string',
3131
'expiry_date' => 'required|date',
32-
'remarks' => 'required|string',
32+
'remarks' => 'string',
3333
];
3434
}
3535
}

0 commit comments

Comments
 (0)