Skip to content

Commit 9237302

Browse files
authored
Use strict check on null instead of empty(), so modifiers with 0 won't be empty + add a test case for it. fixes #285 (#286)
1 parent 5622dab commit 9237302

File tree

2 files changed

+2
-1
lines changed

2 files changed

+2
-1
lines changed

src/Lexers/ModelLexer.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -232,7 +232,7 @@ private function buildColumn(string $name, string $definition)
232232

233233
if (isset(self::$modifiers[strtolower($value)])) {
234234
$modifierAttributes = $parts[1] ?? null;
235-
if (empty($modifierAttributes)) {
235+
if ($modifierAttributes === null) {
236236
$modifiers[] = self::$modifiers[strtolower($value)];
237237
} else {
238238
$modifiers[] = [self::$modifiers[strtolower($value)] => $modifierAttributes];

tests/Feature/Lexers/ModelLexerTest.php

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -662,6 +662,7 @@ public function modifierAttributesProvider()
662662
return [
663663
['default:5', 'default', 5],
664664
['default:0.00', 'default', 0.00],
665+
['default:0', 'default', 0],
665666
['default:string', 'default', 'string'],
666667
["default:'empty'", 'default', "'empty'"],
667668
['default:""', 'default', '""'],

0 commit comments

Comments
 (0)