BaseCoding

Author: jasonmccreary

src/Generators/Statements/NotificationGenerator.php

@@ -29,13 +29,11 @@ public function output(array $tree): array
         foreach ($tree['controllers'] as $controller) {
             foreach ($controller->methods() as $method => $statements) {
                 foreach ($statements as $statement) {
-                    if (!$statement instanceof SendStatement) {
+                    if (! $statement instanceof SendStatement) {
                         continue;
                     }
 
-                    if ($statement->type() !== SendStatement::TYPE_NOTIFICATION_WITH_FACADE
-                        && $statement->type() !== SendStatement::TYPE_NOTIFICATION_WITH_MODEL
-                    ) {
+                    if (! $statement->isNotification()) {
                         continue;
                     }
 

src/Generators/TestGenerator.php

@@ -116,9 +116,7 @@ protected function buildTestCases(Controller $controller)
 
             foreach ($statements as $statement) {
                 if ($statement instanceof SendStatement) {
-                    if ($statement->type() === SendStatement::TYPE_NOTIFICATION_WITH_FACADE
-                        || $statement->type() === SendStatement::TYPE_NOTIFICATION_WITH_MODEL
-                    ) {
+                    if ($statement->isNotification()) {
                         $this->addImport($controller, 'Illuminate\\Support\\Facades\\Notification');
                         $this->addImport($controller, config('blueprint.namespace') . '\\Notification\\' . $statement->mail());
 

src/Models/Statements/SendStatement.php

@@ -6,9 +6,7 @@
 class SendStatement
 {
     const TYPE_MAIL = 'mail';
-
     const TYPE_NOTIFICATION_WITH_FACADE = 'notification_with_facade';
-
     const TYPE_NOTIFICATION_WITH_MODEL = 'notification_with_model';
 
     /**
@@ -75,6 +73,11 @@ public function output()
         return $this->mailOutput();
     }
 
+    public function isNotification()
+    {
+       return $this->type() === SendStatement::TYPE_NOTIFICATION_WITH_FACADE || $this->type() === SendStatement::TYPE_NOTIFICATION_WITH_MODEL;
+    }
+
     private function mailOutput()
     {
         $code = 'Mail::';