Fix boolean column default modifier (#426)

Co-authored-by: Mokhlas Hussein <[email protected]>
Co-authored-by: Nathan Esayeas <[email protected]>

Author: 3 people

src/Generators/MigrationGenerator.php

@@ -211,7 +211,13 @@ protected function buildDefinition(Model $model)
 
             foreach ($modifiers as $modifier) {
                 if (is_array($modifier)) {
-                    $column_definition .= sprintf("->%s('%s')", key($modifier), addslashes(current($modifier)));
+                    $modifierKey = key($modifier);
+                    $modifierValue = addslashes(current($modifier));
+                    if (in_array($dataType, ['boolean', 'tinyinteger']) && $modifierKey === 'default') {
+                        $column_definition .= sprintf("->%s(%s)", $modifierKey, $modifierValue);
+                    } else {
+                        $column_definition .= sprintf("->%s('%s')", $modifierKey, $modifierValue);
+                    }
                 } elseif ($modifier === 'unsigned' && Str::startsWith($dataType, 'unsigned')) {
                     continue;
                 } elseif ($modifier === 'nullable' && Str::startsWith($dataType, 'nullable')) {

tests/Feature/Generators/MigrationGeneratorTest.php

@@ -870,6 +870,7 @@ public function modelTreeDataProvider()
             ['drafts/resource-statements.yaml', 'database/migrations/timestamp_create_users_table.php', 'migrations/resource-statements.php'],
             ['drafts/enum-options.yaml', 'database/migrations/timestamp_create_messages_table.php', 'migrations/enum-options.php'],
             ['drafts/columns-with-comments.yaml', 'database/migrations/timestamp_create_professions_table.php', 'migrations/columns-with-comments.php'],
+            ['drafts/boolean-column-default.yaml', 'database/migrations/timestamp_create_posts_table.php', 'migrations/boolean-column-default.php'],
         ];
     }
 }

tests/fixtures/drafts/boolean-column-default.yaml

@@ -0,0 +1,8 @@
+models:
+  Post:
+    title: string:400
+    content: longtext
+    show: boolean default:1
+    hide: boolean default:0
+    draft: boolean default:true
+    published: boolean default:false

tests/fixtures/migrations/boolean-column-default.php

@@ -0,0 +1,37 @@
+<?php
+
+use Illuminate\Database\Migrations\Migration;
+use Illuminate\Database\Schema\Blueprint;
+use Illuminate\Support\Facades\Schema;
+
+class CreatePostsTable extends Migration
+{
+    /**
+     * Run the migrations.
+     *
+     * @return void
+     */
+    public function up()
+    {
+        Schema::create('posts', function (Blueprint $table) {
+            $table->id();
+            $table->string('title', 400);
+            $table->longText('content');
+            $table->boolean('show')->default(1);
+            $table->boolean('hide')->default(0);
+            $table->boolean('draft')->default(true);
+            $table->boolean('published')->default(false);
+            $table->timestamps();
+        });
+    }
+
+    /**
+     * Reverse the migrations.
+     *
+     * @return void
+     */
+    public function down()
+    {
+        Schema::dropIfExists('posts');
+    }
+}