Skip to content

Commit a74246c

Browse files
committed
Convert inline TODO to issues
1 parent b9cb845 commit a74246c

File tree

6 files changed

+8
-14
lines changed

6 files changed

+8
-14
lines changed

src/BlueprintCommand.php

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -39,14 +39,13 @@ public function __construct(Filesystem $files)
3939
/**
4040
* Execute the console command.
4141
*
42-
* @param \App\DripEmailer $drip
4342
* @return mixed
4443
*/
4544
public function handle()
4645
{
4746
$contents = $this->files->get($this->argument('draft'));
4847

49-
$blueprint = new Blueprint(); // TODO: resolve or make static for extensibility
48+
$blueprint = new Blueprint();
5049

5150
$blueprint->registerLexer(new \Blueprint\Lexers\ModelLexer());
5251

@@ -81,4 +80,4 @@ protected function getOptions()
8180
{
8281
return [];
8382
}
84-
}
83+
}

src/Generators/FactoryGenerator.php

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,6 @@ public function output(array $tree): array
2121
{
2222
$output = [];
2323

24-
// TODO: what if changing an existing model
2524
$stub = $this->files->get(STUBS_PATH . '/factory.stub');
2625

2726
/** @var \Blueprint\Model $model */
@@ -114,7 +113,7 @@ protected function fakerData(string $name)
114113
protected function fakerDataType(string $type)
115114
{
116115
$fakeableTypes = [
117-
'id' => 'randomDigitNotNull', // TODO: override with closure generator
116+
'id' => 'randomDigitNotNull',
118117
'string' => 'word',
119118
'text' => 'text',
120119
'date' => 'date()',
@@ -133,4 +132,4 @@ protected function fakerDataType(string $type)
133132

134133
return $fakeableTypes[$type] ?? null;
135134
}
136-
}
135+
}

src/Generators/MigrationGenerator.php

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,6 @@ public function output(array $tree): array
2222
{
2323
$output = [];
2424

25-
// TODO: what if changing an existing model
2625
$stub = $this->files->get(STUBS_PATH . '/migration.stub');
2726

2827
/** @var \Blueprint\Model $model */
@@ -100,4 +99,4 @@ protected function getPath(Model $model)
10099
{
101100
return 'database/migrations/' . \Carbon\Carbon::now()->format('Y_m_d_His') . '_create_' . $model->tableName() . '_table.php';
102101
}
103-
}
102+
}

src/Generators/ModelGenerator.php

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,6 @@ public function output(array $tree): array
2020
{
2121
$output = [];
2222

23-
// TODO: what if changing an existing model
2423
$stub = $this->files->get(STUBS_PATH . '/model/class.stub');
2524

2625
/** @var \Blueprint\Model $model */
@@ -149,4 +148,4 @@ private function propertyStub(string $stub)
149148

150149
return $stubs[$stub];
151150
}
152-
}
151+
}

tests/Feature/Generator/MigrationGeneratorTest.php

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -73,7 +73,6 @@ public function modelTreeDataProvider()
7373
['definitions/readme-example.bp', 'database/migrations/timestamp_create_posts_table.php', 'migrations/readme-example.php'],
7474
['definitions/model-identities.bp', 'database/migrations/timestamp_create_relationships_table.php', 'migrations/identity-columns.php'],
7575
['definitions/model-modifiers.bp', 'database/migrations/timestamp_create_modifiers_table.php', 'migrations/modifiers.php'],
76-
// TODO: optimizations like nullableTimestamp, unsignedInteger, etc
7776
];
7877
}
79-
}
78+
}

tests/Feature/Generator/ModelGeneratorTest.php

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -77,7 +77,6 @@ public function modelTreeDataProvider()
7777
{
7878
return [
7979
['definitions/readme-example.bp', 'app/Post.php', 'models/readme-example.php'],
80-
// TODO: relationships
8180
];
8281
}
83-
}
82+
}

0 commit comments

Comments
 (0)