Add fake_nullable config (#127)

Author: Naoray

config/blueprint.php

@@ -56,4 +56,5 @@
     */
     'generate_phpdocs' => false,
 
+    'fake_nullables' => true,
 ];

src/Generators/FactoryGenerator.php

@@ -2,9 +2,10 @@
 
 namespace Blueprint\Generators;
 
-use Blueprint\Contracts\Generator;
 use Blueprint\Models\Model;
 use Illuminate\Support\Str;
+use Blueprint\Models\Column;
+use Blueprint\Contracts\Generator;
 
 class FactoryGenerator implements Generator
 {
@@ -31,7 +32,7 @@ public function output(array $tree): array
             if (!$this->files->exists(dirname($path))) {
                 $this->files->makeDirectory(dirname($path), 0755, true);
             }
-            
+
             $this->files->put($path, $this->populateStub($stub, $model));
 
             $output['created'][] = $path;
@@ -63,8 +64,10 @@ protected function buildDefinition(Model $model)
     {
         $definition = '';
 
+        $fillable = $this->fillableColumns($model->columns());
+
         /** @var \Blueprint\Models\Column $column */
-        foreach ($model->columns() as $column) {
+        foreach ($fillable as $column) {
             if ($column->name() === 'id') {
                 continue;
             }
@@ -76,7 +79,7 @@ protected function buildDefinition(Model $model)
                 $definition .= self::INDENT . "'{$column->name()}' => ";
                 $definition .= sprintf('factory(%s::class)', '\\' . $model->fullyQualifiedNamespace() . '\\' . $class);
                 $definition .= ',' . PHP_EOL;
-            } elseif (in_array($column->dataType(), ['enum', 'set']) and !empty($column->attributes())) {
+            } elseif (in_array($column->dataType(), ['enum', 'set']) && !empty($column->attributes())) {
                 $definition .= self::INDENT . "'{$column->name()}' => ";
                 $faker = $this->fakerData($column->name()) ?? $this->fakerDataType($column->dataType());
                 $definition .= '$faker->' . $faker;
@@ -114,6 +117,17 @@ protected function buildDefinition(Model $model)
         return trim($definition);
     }
 
+    private function fillableColumns(array $columns): array
+    {
+        if (config('blueprint.fake_nullables')) {
+            return $columns;
+        }
+
+        return array_filter($columns, function (Column $column) {
+            return !in_array('nullable', $column->modifiers());
+        });
+    }
+
     public static function fakerData(string $name)
     {
         static $fakeableNames = [

tests/Feature/Generator/FactoryGeneratorTest.php

@@ -2,9 +2,9 @@
 
 namespace Tests\Feature\Generators;
 
+use Tests\TestCase;
 use Blueprint\Blueprint;
 use Blueprint\Generators\FactoryGenerator;
-use Tests\TestCase;
 
 /**
  * @see FactoryGenerator
@@ -67,6 +67,30 @@ public function output_writes_migration_for_model_tree($definition, $path, $migr
         $this->assertEquals(['created' => [$path]], $this->subject->output($tree));
     }
 
+    /**
+     * @test
+     */
+    public function output_ignores_nullables_if_fake_nullables_configuration_is_set_to_false()
+    {
+        $this->app['config']->set('blueprint.fake_nullables', false);
+
+        $this->files->expects('stub')
+            ->with('factory.stub')
+            ->andReturn(file_get_contents('stubs/factory.stub'));
+
+        $this->files->expects('exists')
+            ->with('database/factories')
+            ->andReturnTrue();
+
+        $this->files->expects('put')
+            ->with('database/factories/OrderFactory.php', $this->fixture('factories/fake-nullables.php'));
+
+        $tokens = $this->blueprint->parse($this->fixture('definitions/model-key-constraints.bp'));
+        $tree = $this->blueprint->analyze($tokens);
+
+        $this->assertEquals(['created' => ['database/factories/OrderFactory.php']], $this->subject->output($tree));
+    }
+
     /**
      * @test
      */
@@ -124,7 +148,7 @@ public function modelTreeDataProvider()
             ['definitions/team.bp', 'database/factories/TeamFactory.php', 'factories/team.php'],
             ['definitions/unconventional.bp', 'database/factories/TeamFactory.php', 'factories/unconventional.php'],
             ['definitions/model-modifiers.bp', 'database/factories/ModifierFactory.php', 'factories/model-modifiers.php'],
-            ['definitions/model-key-constraints.bp', 'database/factories/OrderFactory.php', 'factories/model-key-constraints.php']
+            ['definitions/model-key-constraints.bp', 'database/factories/OrderFactory.php', 'factories/model-key-constraints.php'],
         ];
     }
 }

tests/fixtures/factories/fake-nullables.php

@@ -0,0 +1,14 @@
+<?php
+
+/** @var \Illuminate\Database\Eloquent\Factory $factory */
+
+use App\Order;
+use Faker\Generator as Faker;
+
+$factory->define(Order::class, function (Faker $faker) {
+    return [
+        'user_id' => factory(\App\User::class),
+        'subscription_id' => factory(\App\Subscription::class),
+        'meta' => '[]',
+    ];
+});