Correct order for supplemental routes

Per the documentation, additional routes to a resource controller should be defined before the call to the `Route::resource` method.

Author: jasonmccreary

src/Generators/RouteGenerator.php

@@ -51,11 +51,14 @@ protected function buildRoutes(Controller $controller)
     {
         $routes = '';
         $methods = array_keys($controller->methods());
-
         $className = $this->getClassName($controller);
-
         $slug = Str::kebab($controller->prefix());
 
+        foreach (array_diff($methods, Controller::$resourceMethods) as $method) {
+            $routes .= $this->buildRouteLine($className, $slug, $method);
+            $routes .= PHP_EOL;
+        }
+
         $resource_methods = array_intersect($methods, Controller::$resourceMethods);
         if (count($resource_methods)) {
             $routes .= $controller->isApiResource()
@@ -77,12 +80,6 @@ protected function buildRoutes(Controller $controller)
             $routes .= ';' . PHP_EOL;
         }
 
-        $methods = array_diff($methods, Controller::$resourceMethods);
-        foreach ($methods as $method) {
-            $routes .= $this->buildRouteLine($className, $slug, $method);
-            $routes .= PHP_EOL;
-        }
-
         return trim($routes);
     }
 

tests/Feature/Generators/RouteGeneratorTest.php

@@ -37,9 +37,9 @@ protected function setUp(): void
      */
     public function output_generates_nothing_for_empty_tree()
     {
-        $this->files->shouldNotHaveReceived('append');
-
         $this->assertEquals([], $this->subject->output(new Tree(['controllers' => []])));
+
+        $this->files->shouldNotHaveReceived('append');
     }
 
     /**

tests/fixtures/routes/non-cruddy.php

@@ -1,8 +1,8 @@
 
 
-Route::resource('some', 'SomeController')->only('index', 'show');
 Route::get('some/whatever', 'SomeController@whatever');
 Route::get('some/slug-name', 'SomeController@slugName');
+Route::resource('some', 'SomeController')->only('index', 'show');
 
 Route::get('subscriptions/resume', 'SubscriptionsController@resume');
 

tests/fixtures/routes/respond-statements.php

@@ -1,4 +1,4 @@
 
 
-Route::resource('post', 'Api\PostController')->only('index', 'store');
 Route::get('post/error', 'Api\PostController@error');
+Route::resource('post', 'Api\PostController')->only('index', 'store');