Change api.delete to return proper "no content" (#331)

Author: spaceemotion

src/Lexers/ControllerLexer.php

@@ -125,7 +125,7 @@ private function resourceTokens()
             ],
             'api.destroy' => [
                 'delete' => '[singular]',
-                'respond' => 200,
+                'respond' => 204,
             ],
         ];
     }

tests/fixtures/controllers/certificate-controller.php

@@ -64,6 +64,6 @@ public function destroy(Request $request, Certificate $certificate)
     {
         $certificate->delete();
 
-        return response()->noContent(200);
+        return response()->noContent();
     }
 }

tests/fixtures/controllers/certificate-type-controller.php

@@ -64,6 +64,6 @@ public function destroy(Request $request, CertificateType $certificateType)
     {
         $certificateType->delete();
 
-        return response()->noContent(200);
+        return response()->noContent();
     }
 }

tests/fixtures/controllers/custom-models-namespace.php

@@ -64,6 +64,6 @@ public function destroy(Request $request, Tag $tag)
     {
         $tag->delete();
 
-        return response()->noContent(200);
+        return response()->noContent();
     }
 }

tests/fixtures/tests/api-shorthand-validation.php

@@ -144,7 +144,7 @@ public function destroy_deletes_and_responds_with()
 
         $response = $this->delete(route('certificate.destroy', $certificate));
 
-        $response->assertOk();
+        $response->assertNoContent();
 
         $this->assertDeleted($certificate);
     }

tests/fixtures/tests/certificate-pascal-case-example.php

@@ -144,7 +144,7 @@ public function destroy_deletes_and_responds_with()
 
         $response = $this->delete(route('certificate.destroy', $certificate));
 
-        $response->assertOk();
+        $response->assertNoContent();
 
         $this->assertDeleted($certificate);
     }

tests/fixtures/tests/certificate-type-pascal-case-example.php

@@ -119,7 +119,7 @@ public function destroy_deletes_and_responds_with()
 
         $response = $this->delete(route('certificate-type.destroy', $certificateType));
 
-        $response->assertOk();
+        $response->assertNoContent();
 
         $this->assertDeleted($certificateType);
     }

tests/fixtures/tests/models-with-custom-namespace.php

@@ -131,7 +131,7 @@ public function destroy_deletes_and_responds_with()
 
         $response = $this->delete(route('category.destroy', $category));
 
-        $response->assertOk();
+        $response->assertNoContent();
 
         $this->assertDeleted($category);
     }