Use $request->validated with validate statement (#308)

Author: jasonmccreary

src/Models/Statements/EloquentStatement.php

@@ -54,7 +54,12 @@ public function output(string $controller_prefix, string $context, bool $using_v
                 $code = "$" . Str::camel($model);
                 $code .= ' = ';
                 $code .= $model;
-                $code .= '::create($request->all());';
+
+                if ($using_validation) {
+                    $code .= '::create($request->validated());';
+                } else {
+                    $code .= '::create($request->all());';
+                }
             } else {
                 $code = "$" . Str::camel($model) . '->save();';
             }

tests/Feature/Generator/ControllerGeneratorTest.php

@@ -174,6 +174,7 @@ public function controllerTreeDataProvider()
             ['drafts/nested-components.yaml', 'app/Http/Controllers/Admin/UserController.php', 'controllers/nested-components.php'],
             ['drafts/respond-statements.yaml', 'app/Http/Controllers/Api/PostController.php', 'controllers/respond-statements.php'],
             ['drafts/resource-statements.yaml', 'app/Http/Controllers/UserController.php', 'controllers/resource-statements.php'],
+            ['drafts/save-without-validation.yaml', 'app/Http/Controllers/PostController.php', 'controllers/save-without-validation.php'],
         ];
     }
 }

tests/Unit/Models/Statements/EloquentStatementTest.php

@@ -50,6 +50,16 @@ public function output_generates_code_for_save_using_create()
         $this->assertEquals('$post = Post::create($request->all());', $subject->output('', 'store'));
     }
 
+    /**
+     * @test
+     */
+    public function output_generates_code_for_save_using_create_when_validation_is_used()
+    {
+        $subject = new EloquentStatement('save', 'Post');
+
+        $this->assertEquals('$post = Post::create($request->validated());', $subject->output('', 'store', true));
+    }
+
     /**
      * @test
      */

tests/fixtures/controllers/certificate-controller.php

@@ -28,7 +28,7 @@ public function index(Request $request)
      */
     public function store(CertificateStoreRequest $request)
     {
-        $certificate = Certificate::create($request->all());
+        $certificate = Certificate::create($request->validated());
 
         return new CertificateResource($certificate);
     }

tests/fixtures/controllers/certificate-type-controller.php

@@ -28,7 +28,7 @@ public function index(Request $request)
      */
     public function store(CertificateTypeStoreRequest $request)
     {
-        $certificateType = CertificateType::create($request->all());
+        $certificateType = CertificateType::create($request->validated());
 
         return new CertificateTypeResource($certificateType);
     }

tests/fixtures/controllers/controller-configured.php

@@ -26,7 +26,7 @@ public function index(Request $request)
      */
     public function store(UserStoreRequest $request)
     {
-        $user = User::create($request->all());
+        $user = User::create($request->validated());
 
         $request->session()->flash('user.name', $user->name);
 

tests/fixtures/controllers/custom-models-namespace.php

@@ -28,7 +28,7 @@ public function index(Request $request)
      */
     public function store(TagStoreRequest $request)
     {
-        $tag = Tag::create($request->all());
+        $tag = Tag::create($request->validated());
 
         return new TagResource($tag);
     }

tests/fixtures/controllers/nested-components.php

@@ -30,7 +30,7 @@ public function index(Request $request)
      */
     public function store(UserStoreRequest $request)
     {
-        $user = User::create($request->all());
+        $user = User::create($request->validated());
 
         Notification::send($user, new InviteNotification($user));
 

tests/fixtures/controllers/readme-example-notification-facade.php

@@ -29,7 +29,7 @@ public function index(Request $request)
      */
     public function store(PostStoreRequest $request)
     {
-        $post = Post::create($request->all());
+        $post = Post::create($request->validated());
 
         Notification::send($post->author, new ReviewNotification($post));
 

tests/fixtures/controllers/readme-example-notification-model.php

@@ -27,7 +27,7 @@ public function index(Request $request)
      */
     public function store(PostStoreRequest $request)
     {
-        $post = Post::create($request->all());
+        $post = Post::create($request->validated());
 
         $post->author->notify(new ReviewNotification($post));