Fix factory generation for morphs column type (#135)

Author: diogogomeswww

src/Generators/FactoryGenerator.php

@@ -2,10 +2,10 @@
 
 namespace Blueprint\Generators;
 
+use Blueprint\Contracts\Generator;
+use Blueprint\Models\Column;
 use Blueprint\Models\Model;
 use Illuminate\Support\Str;
-use Blueprint\Models\Column;
-use Blueprint\Contracts\Generator;
 
 class FactoryGenerator implements Generator
 {
@@ -106,6 +106,12 @@ protected function buildDefinition(Model $model)
             } elseif ($column->dataType() === 'json') {
                 $default = $column->defaultValue() ?? "'{}'";
                 $definition .= self::INDENT . "'{$column->name()}' => {$default}," . PHP_EOL;
+            } elseif ($column->dataType() === 'morphs') {
+                if ($column->isNullable()) {
+                    continue;
+                }
+                $definition .= sprintf('%s%s => $faker->%s,%s', self::INDENT, "'{$column->name()}_id'", self::fakerDataType('id'), PHP_EOL);
+                $definition .= sprintf('%s%s => $faker->%s,%s', self::INDENT, "'{$column->name()}_type'", self::fakerDataType('string'), PHP_EOL);
             } else {
                 $definition .= self::INDENT . "'{$column->name()}' => ";
                 $faker = self::fakerData($column->name()) ?? self::fakerDataType($column->dataType());

src/Generators/MigrationGenerator.php

@@ -111,7 +111,7 @@ protected function buildDefinition(Model $model)
                 $dataType = 'unsigned' . ucfirst($dataType);
             }
 
-            if (in_array($dataType, self::NULLABLE_TYPES) && in_array('nullable', $column->modifiers())) {
+            if (in_array($dataType, self::NULLABLE_TYPES) && $column->isNullable()) {
                 $dataType = 'nullable' . ucfirst($dataType);
             }
 

src/Models/Column.php

@@ -45,4 +45,9 @@ public function defaultValue()
                 return $key === 'default';
             });
     }
+
+    public function isNullable()
+    {
+        return in_array('nullable', $this->modifiers);
+    }
 }

tests/Unit/Models/ColumnTest.php

@@ -0,0 +1,18 @@
+<?php
+
+namespace Tests\Unit\Models;
+
+use Blueprint\Models\Column;
+use PHPUnit\Framework\TestCase;
+
+class ColumnTest extends TestCase
+{
+    /** @test */
+    public function it_knows_if_its_nullable()
+    {
+        $this->assertTrue((new Column('foo', 'string', ['nullable']))->isNullable());
+
+        $this->assertFalse((new Column('foo', 'string', []))->isNullable());
+        $this->assertFalse((new Column('foo', 'string', ['something']))->isNullable());
+    }
+}

tests/fixtures/definitions/phone.bp

@@ -5,3 +5,5 @@ models:
     phone_number: text
     type: enum:home,cell
     status: set:archived,deleted
+    foo: morphs
+    bar: morphs nullable

tests/fixtures/factories/phone.php

@@ -12,5 +12,7 @@
         'phone_number' => $faker->phoneNumber,
         'type' => $faker->randomElement(["home","cell"]),
         'status' => $faker->randomElement(["archived","deleted"]),
+        'foo_id' => $faker->randomDigitNotNull,
+        'foo_type' => $faker->word,
     ];
 });