Throw exception for unparseable URLs (#22)

Author: Attia-Ahmed

src/Models/Request.php

@@ -3,6 +3,7 @@
 namespace Shift\CurlConverter\Models;
 
 use Illuminate\Support\Str;
+use InvalidArgumentException;
 
 class Request
 {
@@ -36,6 +37,10 @@ public static function create(array $data): self
     {
         $url = parse_url($data['url']);
 
+        if ($url === false) {
+            throw new InvalidArgumentException(sprintf('The "%s" URL is invalid.', $data['url']));
+        }
+
         $request = new self(self::buildUrl($url), $data['method'] ?? 'GET');
 
         if (isset($url['query'])) {

tests/Feature/Console/Commands/CurlCommandTest.php

@@ -3,6 +3,7 @@
 namespace Tests\Feature\Console\Commands;
 
 use Illuminate\Support\Facades\Artisan;
+use InvalidArgumentException;
 use Tests\TestCase;
 
 class CurlCommandTest extends TestCase
@@ -20,6 +21,14 @@ public function it_converts_curl_requests_to_http_client_code($fixture)
         $this->assertSame($this->fixture($fixture . '.out'), $output);
     }
 
+    public function test_it_throw_exception_when_for_invalid_url()
+    {
+        $this->expectException(InvalidArgumentException::class);
+        $this->expectExceptionMessage('The "https://{domain:port}/api/{id}/" URL is invalid.');
+
+        Artisan::call('shift:curl -X GET "https://{domain:port}/api/{id}/"');
+    }
+
     public function curlCommandFixtures()
     {
         return [