Fix undefined variable $e in failover loops for image, audio, transcription, embeddings, and reranking (#225)

Author: sulimanbenhalim

src/PendingResponses/PendingAudioGeneration.php

@@ -75,6 +75,8 @@ public function generate(Lab|array|string|null $provider = null, ?string $model
             $provider ?? config('ai.default_for_audio'), $model
         );
 
+        $lastException = null;
+
         foreach ($providers as $provider => $model) {
             $provider = Ai::fakeableAudioProvider($provider);
 
@@ -85,13 +87,15 @@ public function generate(Lab|array|string|null $provider = null, ?string $model
                     $this->text, $this->voice, $this->instructions, $model
                 );
             } catch (FailoverableException $e) {
+                $lastException = $e;
+
                 event(new ProviderFailedOver($provider, $model, $e));
 
                 continue;
             }
         }
 
-        throw $e;
+        throw $lastException;
     }
 
     /**

src/PendingResponses/PendingEmbeddingsGeneration.php

@@ -58,6 +58,8 @@ public function generate(Lab|array|string|null $provider = null, ?string $model
             $provider ?? config('ai.default_for_embeddings'), $model
         );
 
+        $lastException = null;
+
         foreach ($providers as $provider => $model) {
             $provider = Ai::fakeableEmbeddingProvider($provider);
 
@@ -75,13 +77,15 @@ public function generate(Lab|array|string|null $provider = null, ?string $model
                     fn ($response) => $this->cacheEmbeddings($provider, $model, $dimensions, $response)
                 );
             } catch (FailoverableException $e) {
+                $lastException = $e;
+
                 event(new ProviderFailedOver($provider, $model, $e));
 
                 continue;
             }
         }
 
-        throw $e;
+        throw $lastException;
     }
 
     /**

src/PendingResponses/PendingImageGeneration.php

@@ -118,6 +118,8 @@ public function generate(Lab|array|string|null $provider = null, ?string $model
             $provider ?? config('ai.default_for_images'), $model
         );
 
+        $lastException = null;
+
         foreach ($providers as $provider => $model) {
             $provider = Ai::fakeableImageProvider($provider);
 
@@ -128,13 +130,15 @@ public function generate(Lab|array|string|null $provider = null, ?string $model
                     $this->prompt, $this->attachments, $this->size, $this->quality, $model, $this->timeout
                 );
             } catch (FailoverableException $e) {
+                $lastException = $e;
+
                 event(new ProviderFailedOver($provider, $model, $e));
 
                 continue;
             }
         }
 
-        throw $e;
+        throw $lastException;
     }
 
     /**

src/PendingResponses/PendingReranking.php

@@ -44,6 +44,8 @@ public function rerank(string $query, Lab|array|string|null $provider = null, ?s
             $provider ?? config('ai.default_for_reranking'), $model
         );
 
+        $lastException = null;
+
         foreach ($providers as $provider => $model) {
             $provider = Ai::fakeableRerankingProvider($provider);
 
@@ -52,12 +54,14 @@ public function rerank(string $query, Lab|array|string|null $provider = null, ?s
             try {
                 return $provider->rerank($this->documents, $query, $this->limit, $model);
             } catch (FailoverableException $e) {
+                $lastException = $e;
+
                 event(new ProviderFailedOver($provider, $model, $e));
 
                 continue;
             }
         }
 
-        throw $e;
+        throw $lastException;
     }
 }

src/PendingResponses/PendingTranscriptionGeneration.php

@@ -71,6 +71,8 @@ public function generate(Lab|array|string|null $provider = null, ?string $model
             $provider ?? config('ai.default_for_transcription'), $model
         );
 
+        $lastException = null;
+
         foreach ($providers as $provider => $model) {
             $provider = Ai::fakeableTranscriptionProvider($provider);
 
@@ -79,13 +81,15 @@ public function generate(Lab|array|string|null $provider = null, ?string $model
             try {
                 return $provider->transcribe($this->audio, $this->language, $this->diarize, $model, $this->timeout);
             } catch (FailoverableException $e) {
+                $lastException = $e;
+
                 event(new ProviderFailedOver($provider, $model, $e));
 
                 continue;
             }
         }
 
-        throw $e;
+        throw $lastException;
     }
 
     /**