refactor: improve readability of comma detection

ashleyhindle · ashleyhindle · commit 16874a9cf28e · 2025-08-27T18:36:43.000+01:00
diff --git a/src/Install/Mcp/FileWriter.php b/src/Install/Mcp/FileWriter.php
@@ -179,8 +179,7 @@ protected function needsCommaAfterBrace(string $content, int $bracePosition): bo
         $afterBrace = substr($content, $bracePosition + 1);
         $trimmed = preg_replace('/^\s*(?:\/\/.*$)?/m', '', $afterBrace);
 
-        // If next char is } (empty object) or nothing, no comma needed
-        return ! empty($trimmed) && $trimmed[0] !== '}';
+        return filled($trimmed) && ! Str::startsWith($trimmed, '}');
     }
 
     protected function findMatchingClosingBrace(string $content, int $openBracePos): int|false

Original file line number	Diff line number	Diff line change
`@@ -179,8 +179,7 @@ protected function needsCommaAfterBrace(string $content, int $bracePosition): bo`
`179`	`179`	`$afterBrace = substr($content, $bracePosition + 1);`
`180`	`180`	`$trimmed = preg_replace('/^\s(?:\/\/.$)?/m', '', $afterBrace);`
`181`	`181`
`182`		`- // If next char is } (empty object) or nothing, no comma needed`
`183`		`- return ! empty($trimmed) && $trimmed[0] !== '}';`
	`182`	`+ return filled($trimmed) && ! Str::startsWith($trimmed, '}');`
`184`	`183`	`}`
`185`	`184`
`186`	`185`	`protected function findMatchingClosingBrace(string $content, int $openBracePos): int\|false`