refactor: rename CodingAgent to Agent, streamline detection methods, and remove unused MCP strategies

- Replaced `CodingAgent` interface with `Agent` and updated all references.
- Removed redundant `mcpInstallationStrategy` and `frontmatter` methods in favor of simplified logic.
- Improved `CodeEnvironment` with consolidated detection methods (`isCodingAgent` -> `IsAgent`).
- Adjusted related classes, tests, and docblocks for consistency and clarity.

Author: pushpak1300

src/Console/InstallCommand.php

@@ -9,7 +9,7 @@
 use Illuminate\Support\Arr;
 use Illuminate\Support\Collection;
 use Illuminate\Support\Str;
-use Laravel\Boost\Contracts\CodingAgent;
+use Laravel\Boost\Contracts\Agent;
 use Laravel\Boost\Install\Cli\DisplayHelper;
 use Laravel\Boost\Install\CodeEnvironment\CodeEnvironment;
 use Laravel\Boost\Install\CodeEnvironmentsDetector;
@@ -297,7 +297,7 @@ private function selectCodeEnvironments(string $type, string $label): Collection
 
         $availableEnvironments = $allEnvironments->filter(function (CodeEnvironment $environment) use ($type) {
             return ($type === 'ide' && $environment->isMcpClient()) ||
-                   ($type === 'agent' && $environment->IsCodingAgent());
+                   ($type === 'agent' && $environment->IsAgent());
         });
 
         if ($availableEnvironments->isEmpty()) {
@@ -372,7 +372,7 @@ protected function enactGuidelines(): void
             $agentName = $agent->agentName();
             $displayAgentName = str_pad($agentName, $longestAgentName);
             $this->output->write("  {$displayAgentName}... ");
-            /** @var CodingAgent $agent */
+            /** @var Agent $agent */
             try {
                 (new GuidelineWriter($agent))
                     ->write($composedAiGuidelines);

src/Contracts/CodingAgent.php src/Contracts/Agent.phpsrc/Contracts/CodingAgent.php renamed to src/Contracts/Agent.php

@@ -7,7 +7,7 @@
 /**
  * Agent contract for AI coding assistants that receive guidelines.
  */
-interface CodingAgent
+interface Agent
 {
     /**
      * Get the file path where AI guidelines should be written.

src/Install/CodeEnvironment/ClaudeCode.php

@@ -4,12 +4,12 @@
 
 namespace Laravel\Boost\Install\CodeEnvironment;
 
-use Laravel\Boost\Contracts\CodingAgent;
+use Laravel\Boost\Contracts\Agent;
 use Laravel\Boost\Contracts\McpClient;
 use Laravel\Boost\Install\Enums\McpInstallationStrategy;
 use Laravel\Boost\Install\Enums\Platform;
 
-class ClaudeCode extends CodeEnvironment implements CodingAgent, McpClient
+class ClaudeCode extends CodeEnvironment implements McpClient, Agent
 {
     public function name(): string
     {
@@ -55,9 +55,4 @@ public function guidelinesPath(): string
     {
         return 'CLAUDE.md';
     }
-
-    public function frontmatter(): bool
-    {
-        return false;
-    }
 }

src/Install/CodeEnvironment/CodeEnvironment.php

@@ -7,54 +7,47 @@
 use Illuminate\Contracts\Filesystem\FileNotFoundException;
 use Illuminate\Support\Facades\File;
 use Illuminate\Support\Facades\Process;
-use Laravel\Boost\Contracts\CodingAgent;
+use Laravel\Boost\Contracts\Agent;
 use Laravel\Boost\Contracts\McpClient;
 use Laravel\Boost\Install\Detection\DetectionStrategyFactory;
 use Laravel\Boost\Install\Enums\McpInstallationStrategy;
 use Laravel\Boost\Install\Enums\Platform;
 
 abstract class CodeEnvironment
 {
-    public function __construct(
-        protected readonly DetectionStrategyFactory $strategyFactory
-    ) {
+    public function __construct(protected readonly DetectionStrategyFactory $strategyFactory)
+    {
     }
 
-    /**
-     * Get the internal identifier name for this code environment.
-     *
-     * @return string
-     */
     abstract public function name(): string;
 
-    /**
-     * Get the human-readable display name for this code environment.
-     *
-     * @return string
-     */
     abstract public function displayName(): string;
 
+    public function agentName(): ?string
+    {
+        return $this->name();
+    }
+
+    public function ideName(): ?string
+    {
+        return $this->name();
+    }
+
     /**
      * Get the detection configuration for system-wide installation detection.
      *
      * @param Platform $platform
-     * @return array
+     * @return array{paths?: string[], command?: string, files?: string[]}
      */
     abstract public function systemDetectionConfig(Platform $platform): array;
 
     /**
      * Get the detection configuration for project-specific detection.
      *
-     * @return array
+     * @return array{paths?: string[], files?: string[]}
      */
     abstract public function projectDetectionConfig(): array;
 
-    /**
-     * Determine if this code environment is installed on the system.
-     *
-     * @param Platform $platform
-     * @return bool
-     */
     public function detectOnSystem(Platform $platform): bool
     {
         $config = $this->systemDetectionConfig($platform);
@@ -63,12 +56,6 @@ public function detectOnSystem(Platform $platform): bool
         return $strategy->detect($config, $platform);
     }
 
-    /**
-     * Determine if this code environment is being used in a specific project.
-     *
-     * @param string $basePath
-     * @return bool
-     */
     public function detectInProject(string $basePath): bool
     {
         $config = array_merge($this->projectDetectionConfig(), ['basePath' => $basePath]);
@@ -77,81 +64,36 @@ public function detectInProject(string $basePath): bool
         return $strategy->detect($config);
     }
 
-    /**
-     * Override this method if the agent name is different from the environment name.
-     *
-     * @return ?string
-     */
-    public function agentName(): ?string
+    public function IsAgent(): bool
     {
-        return $this->name();
+        return $this->agentName() && $this instanceof Agent;
     }
 
-    /**
-     * Override this method if the IDE name is different from the environment name.
-     *
-     * @return ?string
-     */
-    public function ideName(): ?string
-    {
-        return $this->name();
-    }
-
-    /**
-     * Determine if this environment supports Agent/Guidelines functionality.
-     *
-     * @return bool
-     */
-    public function IsCodingAgent(): bool
-    {
-        return $this->agentName() !== null && $this instanceof CodingAgent;
-    }
-
-    /**
-     * Determine if this environment supports IDE/MCP functionality.
-     *
-     * @return bool
-     */
     public function isMcpClient(): bool
     {
-        return $this->ideName() !== null && $this instanceof McpClient;
+        return $this->ideName() && $this instanceof McpClient;
     }
 
-    /**
-     * Get the MCP installation strategy for this environment.
-     *
-     * @return McpInstallationStrategy
-     */
     public function mcpInstallationStrategy(): McpInstallationStrategy
     {
-        return McpInstallationStrategy::None;
+        return McpInstallationStrategy::File;
     }
 
-    /**
-     * Get the shell command for MCP installation (shell strategy).
-     *
-     * @return ?string
-     */
     public function shellMcpCommand(): ?string
     {
         return null;
     }
 
-    /**
-     * Get the path to an MCP configuration file (file strategy).
-     *
-     * @return ?string
-     */
     public function mcpConfigPath(): ?string
     {
         return null;
     }
 
-    /**
-     * Get the JSON key for MCP servers in the config file (file strategy).
-     *
-     * @return string
-     */
+    public function frontmatter(): bool
+    {
+        return false;
+    }
+
     public function mcpConfigKey(): string
     {
         return 'mcpServers';
@@ -173,7 +115,7 @@ public function installMcp(string $key, string $command, array $args = [], array
         return match($this->mcpInstallationStrategy()) {
             McpInstallationStrategy::Shell => $this->installShellMcp($key, $command, $args, $env),
             McpInstallationStrategy::File => $this->installFileMcp($key, $command, $args, $env),
-            McpInstallationStrategy::None => false,
+            McpInstallationStrategy::None => false
         };
     }
 

src/Install/CodeEnvironment/Copilot.php

@@ -4,10 +4,10 @@
 
 namespace Laravel\Boost\Install\CodeEnvironment;
 
-use Laravel\Boost\Contracts\CodingAgent;
+use Laravel\Boost\Contracts\Agent;
 use Laravel\Boost\Install\Enums\Platform;
 
-class Copilot extends CodeEnvironment implements CodingAgent
+class Copilot extends CodeEnvironment implements Agent
 {
     public function name(): string
     {
@@ -48,9 +48,4 @@ public function guidelinesPath(): string
     {
         return '.github/copilot-instructions.md';
     }
-
-    public function frontmatter(): bool
-    {
-        return false;
-    }
 }

src/Install/CodeEnvironment/Cursor.php

@@ -4,12 +4,11 @@
 
 namespace Laravel\Boost\Install\CodeEnvironment;
 
-use Laravel\Boost\Contracts\CodingAgent;
+use Laravel\Boost\Contracts\Agent;
 use Laravel\Boost\Contracts\McpClient;
-use Laravel\Boost\Install\Enums\McpInstallationStrategy;
 use Laravel\Boost\Install\Enums\Platform;
 
-class Cursor extends CodeEnvironment implements CodingAgent, McpClient
+class Cursor extends CodeEnvironment implements Agent, McpClient
 {
     public function name(): string
     {
@@ -50,11 +49,6 @@ public function projectDetectionConfig(): array
         ];
     }
 
-    public function mcpInstallationStrategy(): McpInstallationStrategy
-    {
-        return McpInstallationStrategy::File;
-    }
-
     public function mcpConfigPath(): string
     {
         return '.cursor/mcp.json';

src/Install/CodeEnvironment/PhpStorm.php

@@ -4,12 +4,11 @@
 
 namespace Laravel\Boost\Install\CodeEnvironment;
 
-use Laravel\Boost\Contracts\CodingAgent;
+use Laravel\Boost\Contracts\Agent;
 use Laravel\Boost\Contracts\McpClient;
-use Laravel\Boost\Install\Enums\McpInstallationStrategy;
 use Laravel\Boost\Install\Enums\Platform;
 
-class PhpStorm extends CodeEnvironment implements CodingAgent, McpClient
+class PhpStorm extends CodeEnvironment implements Agent, McpClient
 {
     public function name(): string
     {
@@ -56,11 +55,6 @@ public function agentName(): string
         return 'junie';
     }
 
-    public function mcpInstallationStrategy(): McpInstallationStrategy
-    {
-        return McpInstallationStrategy::File;
-    }
-
     public function mcpConfigPath(): string
     {
         return '.junie/mcp/mcp.json';
@@ -70,9 +64,4 @@ public function guidelinesPath(): string
     {
         return '.junie/guidelines.md';
     }
-
-    public function frontmatter(): bool
-    {
-        return false;
-    }
 }

src/Install/CodeEnvironment/VSCode.php

@@ -5,7 +5,6 @@
 namespace Laravel\Boost\Install\CodeEnvironment;
 
 use Laravel\Boost\Contracts\McpClient;
-use Laravel\Boost\Install\Enums\McpInstallationStrategy;
 use Laravel\Boost\Install\Enums\Platform;
 
 class VSCode extends CodeEnvironment implements McpClient
@@ -50,11 +49,6 @@ public function agentName(): ?string
         return null;
     }
 
-    public function mcpInstallationStrategy(): McpInstallationStrategy
-    {
-        return McpInstallationStrategy::File;
-    }
-
     public function mcpConfigPath(): string
     {
         return '.vscode/mcp.json';

src/Install/CodeEnvironment/Zed.php

@@ -5,7 +5,6 @@
 namespace Laravel\Boost\Install\CodeEnvironment;
 
 use Laravel\Boost\Contracts\McpClient;
-use Laravel\Boost\Install\Enums\McpInstallationStrategy;
 use Laravel\Boost\Install\Enums\Platform;
 
 class Zed extends CodeEnvironment implements McpClient
@@ -54,11 +53,6 @@ public function agentName(): ?string
         return null;
     }
 
-    public function mcpInstallationStrategy(): McpInstallationStrategy
-    {
-        return McpInstallationStrategy::File;
-    }
-
     public function mcpConfigPath(): string
     {
         return '.zed/mcp.json';