Skip to content

Commit 377b649

Browse files
committed
refactor: rename methods in InstallCommand for better readability and consistency
1 parent ccbfddf commit 377b649

File tree

1 file changed

+17
-17
lines changed

1 file changed

+17
-17
lines changed

src/Console/InstallCommand.php

Lines changed: 17 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -126,13 +126,13 @@ private function collectInstallationPreferences(): void
126126

127127
private function enact(): void
128128
{
129-
if ($this->installingGuidelines() && ! empty($this->selectedTargetAgents)) {
129+
if ($this->shouldInstallAiGuidelines() && ! empty($this->selectedTargetAgents)) {
130130
$this->enactGuidelines();
131131
}
132132

133133
usleep(750000);
134134

135-
if (($this->installingMcp() || $this->installingHerdMcp()) && $this->selectedTargetIdes->isNotEmpty()) {
135+
if (($this->shouldInstallMcp() || $this->shouldInstallHerdMcp()) && $this->selectedTargetIdes->isNotEmpty()) {
136136
$this->enactMcpServers();
137137
}
138138
}
@@ -171,11 +171,11 @@ private function outro(): void
171171

172172
// Guidelines installed (prefix: g)
173173
$guidelines = [];
174-
if ($this->installingGuidelines()) {
174+
if ($this->shouldInstallAiGuidelines()) {
175175
$guidelines[] = 'g:ai';
176176
}
177177

178-
if ($this->installingStyleGuidelines()) {
178+
if ($this->shouldInstallStyleGuidelines()) {
179179
$guidelines[] = 'g:style';
180180
}
181181

@@ -229,21 +229,21 @@ protected function determineTestEnforcement(bool $ask = true): bool
229229
*/
230230
private function selectBoostFeatures(): Collection
231231
{
232-
$defaultToInstallOptions = ['mcp_server', 'ai_guidelines'];
233-
$toInstallOptions = [
232+
$defaultInstallOptions = ['mcp_server', 'ai_guidelines'];
233+
$installOptions = [
234234
'mcp_server' => 'Boost MCP Server',
235235
'ai_guidelines' => 'Package AI Guidelines (i.e. Framework, Inertia, Pest)',
236236
'style_guidelines' => 'Laravel Style AI Guidelines',
237237
];
238238

239239
if ($this->herd->isMcpAvailable()) {
240-
$toInstallOptions['herd_mcp'] = 'Herd MCP Server';
240+
$installOptions['herd_mcp'] = 'Herd MCP Server';
241241
}
242242

243243
return collect(multiselect(
244-
label: 'What shall we install?',
245-
options: $toInstallOptions,
246-
default: $defaultToInstallOptions,
244+
label: 'What shall we install ?',
245+
options: $installOptions,
246+
default: $defaultInstallOptions,
247247
required: true,
248248
hint: 'Style guidelines are best for new projects',
249249
));
@@ -402,7 +402,7 @@ private function selectTargetAgents(): Collection
402402

403403
protected function enactGuidelines(): void
404404
{
405-
if (! $this->installingGuidelines()) {
405+
if (! $this->shouldInstallAiGuidelines()) {
406406
return;
407407
}
408408

@@ -460,22 +460,22 @@ protected function enactGuidelines(): void
460460
}
461461
}
462462

463-
protected function installingGuidelines(): bool
463+
private function shouldInstallAiGuidelines(): bool
464464
{
465465
return $this->selectedBoostFeatures->contains('ai_guidelines');
466466
}
467467

468-
protected function installingStyleGuidelines(): bool
468+
private function shouldInstallStyleGuidelines(): bool
469469
{
470470
return $this->selectedBoostFeatures->contains('style_guidelines');
471471
}
472472

473-
protected function installingMcp(): bool
473+
private function shouldInstallMcp(): bool
474474
{
475475
return $this->selectedBoostFeatures->contains('mcp_server');
476476
}
477477

478-
protected function installingHerdMcp(): bool
478+
private function shouldInstallHerdMcp(): bool
479479
{
480480
return $this->selectedBoostFeatures->contains('herd_mcp');
481481
}
@@ -544,7 +544,7 @@ protected function enactMcpServers(): void
544544
$results = [];
545545

546546
// Install Laravel Boost MCP if enabled
547-
if ($this->installingMcp()) {
547+
if ($this->shouldInstallMcp()) {
548548
try {
549549
$result = $ide->installMcp('laravel-boost', base_path('artisan'), ['boost:mcp']);
550550

@@ -561,7 +561,7 @@ protected function enactMcpServers(): void
561561
}
562562

563563
// Install Herd MCP if enabled
564-
if ($this->installingHerdMcp()) {
564+
if ($this->shouldInstallHerdMcp()) {
565565
try {
566566
$result = $ide->installMcp(
567567
key: 'herd',

0 commit comments

Comments
 (0)