quality: fix phpstan issues

Author: ashleyhindle

src/BoostServiceProvider.php

@@ -87,14 +87,16 @@ protected function registerCommands(): void
         }
     }
 
-    private function registerRoutes()
+    private function registerRoutes(): void
     {
         Route::post('/_boost/browser-logs', function (Request $request) {
             $logs = $request->input('logs', []);
+            /** @var \Illuminate\Log\Logger $logger */
+            $logger = Log::channel('browser');
 
-            /** @var array{type: 'error'|'warn'|'info'|'log'|'table'|'window_error'|'uncaught_error'|'unhandled_rejection', timestamp: string, data: array, url:string, userAgent:string} $log */
+            /** @var array{type: 'error'|'warn'|'info'|'log'|'table'|'window_error'|'uncaught_error'|'unhandled_rejection', timestamp: string, data: array<mixed>, url:string, userAgent:string} $log */
             foreach ($logs as $log) {
-                Log::channel('browser')->write(
+                $logger->write(
                     level: $this->jsTypeToPsr3($log['type']),
                     message: $this->buildLogMessageFromData($log['data']),
                     context: [
@@ -112,6 +114,7 @@ private function registerRoutes()
     /**
      * Build a string message for the log based on various input types. Single dimensional, and multi:
      * "data":[{"message":"Unhandled Promise Rejection","reason":{"name":"TypeError","message":"NetworkError when attempting to fetch resource.","stack":""}}]
+     * @param array<mixed> $data
      */
     protected function buildLogMessageFromData(array $data): string
     {

src/Concerns/MakesHttpRequests.php

@@ -29,6 +29,9 @@ public function get(string $url): Response
         return $this->client()->get($url);
     }
 
+    /**
+     * @param array<string, mixed> $json
+     */
     public function json(string $url, array $json): Response
     {
         return $this->client()->asJson()->post($url, $json);

src/Console/InstallCommand.php

@@ -227,7 +227,7 @@ private function intro()
         $this->line(' Let\'s give '.$this->colors->bgYellow($this->colors->black($this->projectName)).' a Boost');
     }
 
-    private function outro()
+    private function outro(): void
     {
         // TODO: Pass info to /installed on what we did so it can show specific help
         $text = 'Enjoy the boost 🚀 https://boost.laravel.com/installed';
@@ -270,6 +270,9 @@ protected function shouldEnforceTests(bool $ask = true): bool
         return $enforce;
     }
 
+    /**
+     * @return array<int, string>
+     */
     protected function boostToInstall(): array
     {
         $defaultToInstallOptions = ['mcp_server', 'ai_guidelines'];
@@ -293,6 +296,9 @@ protected function boostToInstall(): array
         );
     }
 
+    /**
+     * @return array<int, string>
+     */
     protected function boostToolsToDisable(): array
     {
         return multiselect(
@@ -303,6 +309,9 @@ protected function boostToolsToDisable(): array
         );
     }
 
+    /**
+     * @return array<int, string>
+     */
     protected function detectProjectAgents(): array
     {
         $agents = [];
@@ -520,7 +529,7 @@ protected function publishAndUpdateConfig(): void
         // Publish config if it doesn't exist
         if (! file_exists($configPath)) {
             $this->newLine();
-            $this->info('Publishing Boost configuration file...');
+            $this->info(' Publishing Boost configuration file...');
 
             Artisan::call('vendor:publish', [
                 '--provider' => 'Laravel\\Boost\\BoostServiceProvider',
@@ -637,6 +646,7 @@ protected function detectLocalization(): bool
     {
         $actuallyUsing = false;
 
+        /** @phpstan-ignore-next-line  */
         return is_dir(base_path('lang')) && $actuallyUsing;
     }
 }

src/Contracts/Ide.php

@@ -7,5 +7,9 @@ interface Ide
 {
     // Things to note: supports relative (absolute path required)? global mcp only? Prefer local file, but if global only we have to add the project name to the server name
 
+    /**
+     * @param array<int, string> $args
+     * @param array<string, string> $env
+     */
     public function installMcp(string $key, string $command, array $args = [], array $env = []): bool;
 }

src/Install/Agents/FileMcpIde.php

@@ -13,6 +13,10 @@ public function mcpPath(): string
         throw new \Exception('Override me');
     }
 
+    /**
+     * @param array<int, string> $args
+     * @param array<string, string> $env
+     */
     public function installMcp(string $key, string $command, array $args = [], array $env = []): bool
     {
         $path = $this->mcpPath();

src/Install/Agents/ShellMcpIde.php

@@ -9,6 +9,10 @@ abstract class ShellMcpIde implements Ide
 {
     protected string $shellCommand = 'echo "{command} {args} {env}"';
 
+    /**
+     * @param array<int, string> $args
+     * @param array<string, string> $env
+     */
     public function installMcp(string $key, string $command, array $args = [], array $env = []): bool
     {
         // -e, --env <env...>           Set environment variables (e.g. -e KEY=value)

src/Install/Cli/DisplayHelper.php

@@ -4,6 +4,9 @@
 
 class DisplayHelper
 {
+    /**
+     * @param array<int, array<int|string, mixed>> $data
+     */
     public static function datatable(array $data, int $cols = 80): void
     {
         if (empty($data)) {
@@ -90,6 +93,9 @@ public static function datatable(array $data, int $cols = 80): void
         echo $bottomBorder.PHP_EOL;
     }
 
+    /**
+     * @param array<int, string> $items
+     */
     public static function grid(array $items, int $cols = 80): void
     {
         if (empty($items)) {

src/Install/GuidelineComposer.php

@@ -14,6 +14,7 @@ class GuidelineComposer
 
     protected string $userGuidelineDir = '.ai/guidelines';
 
+    /** @var Collection<string, string> */
     protected Collection $guidelines;
 
     protected GuidelineConfig $config;
@@ -48,6 +49,9 @@ public function used(): array
         return $this->guidelines()->keys()->toArray();
     }
 
+    /**
+     * @return Collection<string, string>
+     */
     public function guidelines(): Collection
     {
         if (! empty($this->guidelines)) {
@@ -125,7 +129,7 @@ protected function find(): Collection
     }
 
     /**
-     * @return \Illuminate\Support\Collection<\Symfony\Component\Finder\SplFileInfo $file>
+     * @return Collection<string, \Symfony\Component\Finder\SplFileInfo>
      */
     protected function guidelineFilesInDir(string $dirPath): Collection
     {

src/Mcp/Methods/CallToolWithExecutor.php

@@ -10,6 +10,7 @@
 use Laravel\Mcp\Server\Contracts\Methods\Method;
 use Laravel\Mcp\Server\ServerContext;
 use Laravel\Mcp\Server\Tools\ToolResult;
+use Laravel\Mcp\Server\Transport\JsonRpcNotification;
 use Laravel\Mcp\Server\Transport\JsonRpcRequest;
 use Laravel\Mcp\Server\Transport\JsonRpcResponse;
 

src/Mcp/ToolExecutor.php

@@ -18,6 +18,7 @@ public function __construct()
 
     /**
      * Execute a tool with the given arguments
+     * @param array<string, mixed> $arguments
      */
     public function execute(string $toolClass, array $arguments = []): ToolResult
     {
@@ -34,6 +35,7 @@ public function execute(string $toolClass, array $arguments = []): ToolResult
 
     /**
      * Execute tool in a separate process for isolation
+     * @param array<string, mixed> $arguments
      */
     protected function executeInProcess(string $toolClass, array $arguments): ToolResult
     {
@@ -75,6 +77,7 @@ protected function executeInProcess(string $toolClass, array $arguments): ToolRe
 
     /**
      * Execute tool inline (current process)
+     * @param array<string, mixed> $arguments
      */
     protected function executeInline(string $toolClass, array $arguments): ToolResult
     {
@@ -110,6 +113,7 @@ protected function getTimeout(): int
 
     /**
      * Reconstruct a ToolResult from JSON data
+     * @param array<string, mixed> $data
      */
     protected function reconstructToolResult(array $data): ToolResult
     {