Merge remote-tracking branch 'origin/guidelines-galore' into guidelines-galore

Author: ashleyhindle

src/Mcp/Tools/ApplicationInfo.php

@@ -15,7 +15,9 @@
 #[IsReadOnly]
 class ApplicationInfo extends Tool
 {
-    public function __construct(protected Roster $roster, protected GuidelineAssist $guidelineAssist) {}
+    public function __construct(protected Roster $roster, protected GuidelineAssist $guidelineAssist)
+    {
+    }
 
     public function description(): string
     {

src/Mcp/Tools/DatabaseSchema.php

@@ -169,4 +169,4 @@ protected function getGlobalStructure(?string $connection): array
             'sequences' => $driver->getSequences(),
         ];
     }
-}
+}

src/Mcp/Tools/DatabaseSchema/DatabaseSchemaDriver.php

@@ -19,9 +19,9 @@ abstract public function getStoredProcedures(): array;
 
     abstract public function getFunctions(): array;
 
-    abstract public function getTriggers(string $table = null): array;
+    abstract public function getTriggers(?string $table = null): array;
 
     abstract public function getCheckConstraints(string $table): array;
 
     abstract public function getSequences(): array;
-}
+}

src/Mcp/Tools/DatabaseSchema/MySQLSchemaDriver.php

@@ -11,11 +11,11 @@ class MySQLSchemaDriver extends DatabaseSchemaDriver
     public function getViews(): array
     {
         try {
-            return DB::connection($this->connection)->select("
+            return DB::connection($this->connection)->select('
                 SELECT TABLE_NAME as name, VIEW_DEFINITION as definition
                 FROM information_schema.VIEWS
                 WHERE TABLE_SCHEMA = DATABASE()
-            ");
+            ');
         } catch (\Exception $e) {
             return [];
         }
@@ -24,7 +24,7 @@ public function getViews(): array
     public function getStoredProcedures(): array
     {
         try {
-            return DB::connection($this->connection)->select("SHOW PROCEDURE STATUS WHERE Db = DATABASE()");
+            return DB::connection($this->connection)->select('SHOW PROCEDURE STATUS WHERE Db = DATABASE()');
         } catch (\Exception $e) {
             return [];
         }
@@ -33,20 +33,20 @@ public function getStoredProcedures(): array
     public function getFunctions(): array
     {
         try {
-            return DB::connection($this->connection)->select("SHOW FUNCTION STATUS WHERE Db = DATABASE()");
+            return DB::connection($this->connection)->select('SHOW FUNCTION STATUS WHERE Db = DATABASE()');
         } catch (\Exception $e) {
             return [];
         }
     }
 
-    public function getTriggers(string $table = null): array
+    public function getTriggers(?string $table = null): array
     {
         try {
             if ($table) {
-                return DB::connection($this->connection)->select("SHOW TRIGGERS WHERE `Table` = ?", [$table]);
+                return DB::connection($this->connection)->select('SHOW TRIGGERS WHERE `Table` = ?', [$table]);
             }
 
-            return DB::connection($this->connection)->select("SHOW TRIGGERS");
+            return DB::connection($this->connection)->select('SHOW TRIGGERS');
         } catch (\Exception $e) {
             return [];
         }
@@ -55,12 +55,12 @@ public function getTriggers(string $table = null): array
     public function getCheckConstraints(string $table): array
     {
         try {
-            return DB::connection($this->connection)->select("
+            return DB::connection($this->connection)->select('
                 SELECT CONSTRAINT_NAME, CHECK_CLAUSE
                 FROM information_schema.CHECK_CONSTRAINTS
                 WHERE CONSTRAINT_SCHEMA = DATABASE()
                 AND TABLE_NAME = ?
-            ", [$table]);
+            ', [$table]);
         } catch (\Exception $e) {
             return [];
         }
@@ -70,4 +70,4 @@ public function getSequences(): array
     {
         return [];
     }
-}
+}

src/Mcp/Tools/DatabaseSchema/NullSchemaDriver.php

@@ -21,7 +21,7 @@ public function getFunctions(): array
         return [];
     }
 
-    public function getTriggers(string $table = null): array
+    public function getTriggers(?string $table = null): array
     {
         return [];
     }
@@ -35,4 +35,4 @@ public function getSequences(): array
     {
         return [];
     }
-}
+}

src/Mcp/Tools/DatabaseSchema/PostgreSQLSchemaDriver.php

@@ -51,16 +51,16 @@ public function getFunctions(): array
         }
     }
 
-    public function getTriggers(string $table = null): array
+    public function getTriggers(?string $table = null): array
     {
         try {
-            $sql = "
+            $sql = '
                 SELECT trigger_name, event_manipulation, event_object_table, action_statement
                 FROM information_schema.triggers
                 WHERE trigger_schema = current_schema()
-            ";
+            ';
             if ($table) {
-                $sql .= " AND event_object_table = ?";
+                $sql .= ' AND event_object_table = ?';
 
                 return DB::connection($this->connection)->select($sql, [$table]);
             }
@@ -88,13 +88,13 @@ public function getCheckConstraints(string $table): array
     public function getSequences(): array
     {
         try {
-            return DB::connection($this->connection)->select("
+            return DB::connection($this->connection)->select('
                 SELECT sequence_name, start_value, minimum_value, maximum_value, increment
                 FROM information_schema.sequences
                 WHERE sequence_schema = current_schema()
-            ");
+            ');
         } catch (\Exception $e) {
             return [];
         }
     }
-}
+}

src/Mcp/Tools/DatabaseSchema/SQLiteSchemaDriver.php

@@ -31,12 +31,12 @@ public function getFunctions(): array
         return [];
     }
 
-    public function getTriggers(string $table = null): array
+    public function getTriggers(?string $table = null): array
     {
         try {
             $sql = "SELECT name, sql FROM sqlite_master WHERE type = 'trigger'";
             if ($table) {
-                $sql .= " AND tbl_name = ?";
+                $sql .= ' AND tbl_name = ?';
 
                 return DB::connection($this->connection)->select($sql, [$table]);
             }
@@ -56,4 +56,4 @@ public function getSequences(): array
     {
         return [];
     }
-}
+}

src/Mcp/Tools/DatabaseSchema/SchemaDriverFactory.php

@@ -19,4 +19,4 @@ public static function make(?string $connection = null): DatabaseSchemaDriver
             default => new NullSchemaDriver($connection),
         };
     }
-}
+}

tests/Feature/Mcp/Tools/DatabaseSchemaTest.php

@@ -94,4 +94,4 @@
 
     expect($schemaArray['tables'])->toHaveKey('users');
     expect($schemaArray['tables'])->not->toHaveKey('examples');
-});
+});