refactor: simplify guideline building from dir

ashleyhindle · ashleyhindle · commit b7df023369fa · 2025-08-28T12:43:58.000+01:00
diff --git a/src/Install/GuidelineComposer.php b/src/Install/GuidelineComposer.php
@@ -171,12 +171,7 @@ protected function guidelinesDir(string $dirPath): array
             return [];
         }
 
-        $guidelines = [];
-        foreach ($finder as $file) {
-            $guidelines[] = $this->guideline($file->getRealPath());
-        }
-
-        return $guidelines;
+        return array_map(fn ($file) => $this->guideline($file->getRealPath()), iterator_to_array($finder));
     }
 
     /**

Original file line number	Diff line number	Diff line change
`@@ -171,12 +171,7 @@ protected function guidelinesDir(string $dirPath): array`
`171`	`171`	`return [];`
`172`	`172`	`}`
`173`	`173`
`174`		`- $guidelines = [];`
`175`		`- foreach ($finder as $file) {`
`176`		`- $guidelines[] = $this->guideline($file->getRealPath());`
`177`		`- }`
`178`		`-`
`179`		`- return $guidelines;`
	`174`	`+ return array_map(fn ($file) => $this->guideline($file->getRealPath()), iterator_to_array($finder));`
`180`	`175`	`}`
`181`	`176`
`182`	`177`	`/**`