Merge pull request #33 from laravel/ai-68-how-can-we-work-around-requiring-absolute-paths-needed-for

Use absolute path for PHPStorm and relative paths for others

Author: ashleyhindle

.ai/boost/core.blade.php

@@ -22,7 +22,7 @@
 - The 'search-docs' tool is perfect for all Laravel related packages, including Laravel, Inertia, Livewire, Pest, Nova, Nightwatch, etc.
 - You must use this tool to search for Laravel-ecosystem documentation before falling back to other approaches.
 - Search the documentation before making code changes to ensure we are taking the correct approach.
-- Use multiple, broad, simple, topic based queries to start. For example: `rate limiting##routing rate limiting##routing`.
+- Use multiple, broad, simple, topic based queries to start. For example: `['rate limiting', 'routing rate limiting', 'routing']`.
 
 ### Available Search Syntax
 - You can and should pass multiple queries at once. The most relevant results will be returned first.

src/Console/InstallCommand.php

@@ -317,21 +317,12 @@ private function selectCodeEnvironments(string $contractClass, string $label): C
             return collect();
         }
 
-        $options = $availableEnvironments
-            ->filter(function (CodeEnvironment $environment) {
-                // We only show Zed if it's actually installed
-                if ($environment->name() === 'zed' && ! in_array('zed', $this->systemInstalledCodeEnvironments)) {
-                    return false;
-                }
-
-                return true;
-            })
-            ->mapWithKeys(function (CodeEnvironment $environment) use ($config) {
-                $displayMethod = $config['displayMethod'];
-                $displayText = $environment->{$displayMethod}();
+        $options = $availableEnvironments->mapWithKeys(function (CodeEnvironment $environment) use ($config) {
+            $displayMethod = $config['displayMethod'];
+            $displayText = $environment->{$displayMethod}();
 
-                return [get_class($environment) => $displayText];
-            })->sort();
+            return [get_class($environment) => $displayText];
+        })->sort();
 
         $detectedClasses = [];
         $installedEnvNames = array_unique(array_merge(
@@ -341,7 +332,7 @@ private function selectCodeEnvironments(string $contractClass, string $label): C
 
         foreach ($installedEnvNames as $envKey) {
             $matchingEnv = $availableEnvironments->first(fn (CodeEnvironment $env) => strtolower($envKey) === strtolower($env->name()));
-            if ($matchingEnv && ($options->contains($matchingEnv->displayName() || $options->contains($matchingEnv->agentName())))) {
+            if ($matchingEnv) {
                 $detectedClasses[] = get_class($matchingEnv);
             }
         }
@@ -471,6 +462,7 @@ private function installMcpServerConfig(): void
             )->toArray()
         );
 
+        /** @var CodeEnvironment $mcpClient */
         foreach ($this->selectedTargetMcpClient as $mcpClient) {
             $ideName = $mcpClient->mcpClientName();
             $ideDisplay = str_pad($ideName, $longestIdeName);
@@ -479,7 +471,8 @@ private function installMcpServerConfig(): void
 
             if ($this->shouldInstallMcp()) {
                 try {
-                    $result = $mcpClient->installMcp('laravel-boost', 'php', ['./artisan', 'boost:mcp']);
+                    $artisan = $mcpClient->useAbsolutePathForMcp ? base_path('artisan') : './artisan';
+                    $result = $mcpClient->installMcp('laravel-boost', 'php', [$artisan, 'boost:mcp']);
 
                     if ($result) {
                         $results[] = $this->greenTick.' Boost';

src/Install/CodeEnvironment/CodeEnvironment.php

@@ -15,6 +15,8 @@
 
 abstract class CodeEnvironment
 {
+    public bool $useAbsolutePathForMcp = false;
+
     public function __construct(protected readonly DetectionStrategyFactory $strategyFactory)
     {
     }
@@ -36,7 +38,6 @@ public function mcpClientName(): ?string
     /**
      * Get the detection configuration for system-wide installation detection.
      *
-     * @param Platform $platform
      * @return array{paths?: string[], command?: string, files?: string[]}
      */
     abstract public function systemDetectionConfig(Platform $platform): array;
@@ -102,17 +103,14 @@ public function mcpConfigKey(): string
     /**
      * Install MCP server using the appropriate strategy.
      *
-     * @param string $key
-     * @param string $command
      * @param array<int, string> $args
      * @param array<string, string> $env
-     * @return bool
      *
      * @throws FileNotFoundException
      */
     public function installMcp(string $key, string $command, array $args = [], array $env = []): bool
     {
-        return match($this->mcpInstallationStrategy()) {
+        return match ($this->mcpInstallationStrategy()) {
             McpInstallationStrategy::SHELL => $this->installShellMcp($key, $command, $args, $env),
             McpInstallationStrategy::FILE => $this->installFileMcp($key, $command, $args, $env),
             McpInstallationStrategy::NONE => false
@@ -122,11 +120,8 @@ public function installMcp(string $key, string $command, array $args = [], array
     /**
      * Install MCP server using a shell command strategy.
      *
-     * @param string $key
-     * @param string $command
      * @param array<int, string> $args
      * @param array<string, string> $env
-     * @return bool
      */
     protected function installShellMcp(string $key, string $command, array $args = [], array $env = []): bool
     {
@@ -163,11 +158,8 @@ protected function installShellMcp(string $key, string $command, array $args = [
     /**
      * Install MCP server using a file-based configuration strategy.
      *
-     * @param string $key
-     * @param string $command
      * @param array<int, string> $args
      * @param array<string, string> $env
-     * @return bool
      *
      * @throws FileNotFoundException
      */

src/Install/CodeEnvironment/PhpStorm.php

@@ -10,6 +10,8 @@
 
 class PhpStorm extends CodeEnvironment implements Agent, McpClient
 {
+    public bool $useAbsolutePathForMcp = true;
+
     public function name(): string
     {
         return 'phpstorm';

src/Install/CodeEnvironment/Zed.php

@@ -12,7 +12,6 @@
 use Laravel\Boost\Install\CodeEnvironment\Cursor;
 use Laravel\Boost\Install\CodeEnvironment\PhpStorm;
 use Laravel\Boost\Install\CodeEnvironment\VSCode;
-use Laravel\Boost\Install\CodeEnvironment\Zed;
 use Laravel\Boost\Install\Enums\Platform;
 
 class CodeEnvironmentsDetector
@@ -23,7 +22,6 @@ class CodeEnvironmentsDetector
         'vscode' => VSCode::class,
         'cursor' => Cursor::class,
         'claudecode' => ClaudeCode::class,
-        'zed' => Zed::class,
         'copilot' => Copilot::class,
     ];
 

src/Install/CodeEnvironmentsDetector.php

@@ -7,7 +7,7 @@
 use Laravel\Boost\Install\Enums\Platform;
 
 beforeEach(function () {
-    $this->container = new \Illuminate\Container\Container();
+    $this->container = new \Illuminate\Container\Container;
     $this->detector = new CodeEnvironmentsDetector($this->container);
 });
 
@@ -35,12 +35,11 @@
     $otherProgram->shouldReceive('name')->andReturn('other');
 
     // Bind mocked programs to container
-    $container = new \Illuminate\Container\Container();
+    $container = new \Illuminate\Container\Container;
     $container->bind(\Laravel\Boost\Install\CodeEnvironment\PhpStorm::class, fn () => $program1);
     $container->bind(\Laravel\Boost\Install\CodeEnvironment\VSCode::class, fn () => $program2);
     $container->bind(\Laravel\Boost\Install\CodeEnvironment\Cursor::class, fn () => $program3);
     $container->bind(\Laravel\Boost\Install\CodeEnvironment\ClaudeCode::class, fn () => $otherProgram);
-    $container->bind(\Laravel\Boost\Install\CodeEnvironment\Zed::class, fn () => $otherProgram);
     $container->bind(\Laravel\Boost\Install\CodeEnvironment\Copilot::class, fn () => $otherProgram);
 
     $detector = new CodeEnvironmentsDetector($container);
@@ -60,12 +59,11 @@
     $otherProgram->shouldReceive('name')->andReturn('other');
 
     // Bind mocked program to container
-    $container = new \Illuminate\Container\Container();
+    $container = new \Illuminate\Container\Container;
     $container->bind(\Laravel\Boost\Install\CodeEnvironment\PhpStorm::class, fn () => $program1);
     $container->bind(\Laravel\Boost\Install\CodeEnvironment\VSCode::class, fn () => $otherProgram);
     $container->bind(\Laravel\Boost\Install\CodeEnvironment\Cursor::class, fn () => $otherProgram);
     $container->bind(\Laravel\Boost\Install\CodeEnvironment\ClaudeCode::class, fn () => $otherProgram);
-    $container->bind(\Laravel\Boost\Install\CodeEnvironment\Zed::class, fn () => $otherProgram);
     $container->bind(\Laravel\Boost\Install\CodeEnvironment\Copilot::class, fn () => $otherProgram);
 
     $detector = new CodeEnvironmentsDetector($container);
@@ -90,7 +88,7 @@
     $program3->shouldReceive('name')->andReturn('claudecode');
 
     // Bind mocked programs to container
-    $container = new \Illuminate\Container\Container();
+    $container = new \Illuminate\Container\Container;
     $container->bind(\Laravel\Boost\Install\CodeEnvironment\VSCode::class, fn () => $program1);
     $container->bind(\Laravel\Boost\Install\CodeEnvironment\PhpStorm::class, fn () => $program2);
     $container->bind(\Laravel\Boost\Install\CodeEnvironment\ClaudeCode::class, fn () => $program3);
@@ -109,7 +107,7 @@
     $program1->shouldReceive('name')->andReturn('vscode');
 
     // Bind mocked program to container
-    $container = new \Illuminate\Container\Container();
+    $container = new \Illuminate\Container\Container;
     $container->bind(\Laravel\Boost\Install\CodeEnvironment\VSCode::class, fn () => $program1);
 
     $detector = new CodeEnvironmentsDetector($container);