feat: improve package ai guideline install using Roster->packages()

messy WIP for MCP Installation - still exploring

Author: ashleyhindle

.ai/core.md

@@ -5,4 +5,5 @@ The Laravel Boost Guidelines are specifically curated by Laravel maintainers for
 {project.purpose}
 </purpose-of-this-project>
 
-TODO: Add project structure / relevant models / etc.. ? Kind of like Claude's /init, but for every Laravel developer regardless of IDE ? But if they already have that in Claude.md then that's gonna be doubling up and wasting tokens
+# Conventions
+Follow existing conventions. When creating or editing a file, check sibling files for the correct structure, approach, naming.

.ai/inertiajs-laravel/1/core.md renamed to .ai/inertia-laravel/1/core.md

@@ -1 +1,3 @@
+## InertiaJS Laravel Package
+
 Super core inertia js laravel package

.ai/inertiajs-laravel/2/core.md renamed to .ai/inertia-laravel/2/core.md

@@ -7,56 +7,36 @@
 <a href="https://packagist.org/packages/laravel/boost"><img src="https://img.shields.io/packagist/l/boost" alt="License"></a>
 </p>
 
-> This is a template repository for new Laravel AI
-> Assistants. [Start a new repo with this](https://github.com/laravel/boost/generate), clone it locally and search &
-> replace the relevant things below:
->
-> - `Laravel AI Assistant` with the package name (e.g. `Laravel Horizon`)
-> - `boost` references to the vendor name / GitHub url (e.g. `laravel/horizon`) (*)
-> - `boost` references to the publishing name (e.g. `horizon`) (*)
-> - `Laravel\Boost` references to the package namespace (e.g. `Laravel\Horizon`) (*)
-> - `Boost` references to the short package name (e.g. `Horizon`) (*)
-> - `BOOST_` references to the env variable names (e.g. `HORIZON`) (*)
->
-> (*) Name cannot contain spaces.
->
-> After replacing keywords, take the following steps:
->
-> 1. Rename any `Boost` prefixes in `.php` file names in [`src`](./src) to the package name (e.g. `Horizon`)
-> 2. Remove things you don't need like migrations, routes, resources, etc
-> 3. Fill the package short intro and keywords in the [composer.json](./composer.json) file
-> 4. Set the same short intro and keywords in the GitHub repository sidebar and set the website url to the package docs
 > 5. Fill out the package long introduction in the readme
-> 6. Set the correct link to the docs in the readme
 > 7. Replace the `art/logo.svg` with the new package logo
 > 8. Replace the `public/favicon.ico` with the new package favicon (optional)
 > 9. Remove this quote block from your readme
->
-> All that's left for you is to start building your new package! 🛠
+> 10. Write a great README
 
 ## Introduction
 
-Package introduction...
-./artisan vendor:publish --tag=boost-config
+- `composer require laravel/boost`
+- `./artisan vendor:publish --tag=boost-config`
+- `./artisan boost:install`
+
+> [!IMPORTANT]
+> Boost is currently in Beta, is subject to change prior to the v1.0.0 release, and will be updated frequently. All notable changes will be documented in the [changelog](./CHANGELOG.md).
 
 ## Official Documentation
 
 Documentation for Boost can be found on the [Laravel website](https://laravel.com/docs).
 
 ## Contributing
 
-Thank you for considering contributing to Boost! The contribution guide can be found in
-the [Laravel documentation](https://laravel.com/docs/contributions).
+Thank you for considering contributing to Boost! The contribution guide can be found in the [Laravel documentation](https://laravel.com/docs/contributions).
 
 ## Code of Conduct
 
-In order to ensure that the Laravel community is welcoming to all, please review and abide by
-the [Code of Conduct](https://laravel.com/docs/contributions#code-of-conduct).
+In order to ensure that the Laravel community is welcoming to all, please review and abide by the [Code of Conduct](https://laravel.com/docs/contributions#code-of-conduct).
 
 ## Security Vulnerabilities
 
-Please review [our security policy](https://github.com/laravel/envoy/security/policy) on how to report security
-vulnerabilities.
+Please review [our security policy](https://github.com/laravel/boost/security/policy) on how to report security vulnerabilities.
 
 ## License
 

.ai/inertiajs-laravel/core.md renamed to .ai/inertia-laravel/core.md

@@ -13,6 +13,7 @@
 use Laravel\Roster\Enums\Packages;
 use Laravel\Roster\Roster;
 use Symfony\Component\Console\Attribute\AsCommand;
+use Symfony\Component\Finder\Exception\DirectoryNotFoundException;
 use Symfony\Component\Finder\Finder;
 
 use function Laravel\Prompts\intro;
@@ -82,20 +83,28 @@ protected function query()
         //        $this->boostToolsToDisable = $this->boostToolsToDisable(); // Not useful to start
 
         $this->projectPurpose = $this->projectPurpose();
-        $this->enforceTests = $this->shouldEnforceTests(ask: false); // TODO: Only add 'all new code must have a test' guideline if enforced
-        $this->idesToInstallTo = $this->idesToInstallTo(); // To add boost:mcp to the correct file
+        $this->enforceTests = $this->shouldEnforceTests(ask: false);
 
-        // TODO: Only if in $boosttoInstall or whatever
+        $this->idesToInstallTo = $this->idesToInstallTo(); // To add boost:mcp to the correct file
         $this->agentsToInstallTo = $this->agentsToInstallTo(); // AI Guidelines, which file do they go, are they separated, or all in one file?
     }
 
     protected function enact()
     {
-        $composedAiGuidelines = $this->compose();
-        if ($this->installingGuidelines()) {
-            $this->enactGuidelines($composedAiGuidelines);
+        if ($this->installingGuidelines() && !empty($this->agentsToInstallTo)) {
+            $this->enactGuidelines($this->compose());
+        }
+
+        if ($this->installingMcp() && !empty($this->idesToInstallTo)) {
+            echo "\ninstalling mcps now to: ";
+            dump($this->idesToInstallTo);
+        }
+
+        if ($this->installingHerdMcp() && !empty($this->idesToInstallTo)) {
+            echo "\ninstalling herd mcp now to: ";
+            dump($this->idesToInstallTo);
         }
-//        $this->enactMcp();
+
 
         if (in_array('other', $this->idesToInstallTo)) {
             $this->newLine();
@@ -108,6 +117,8 @@ protected function compose(): string
         // TODO: Just move to blade views and compact public properties?
         $composed = collect(['core' => $this->guideline('core.md', [
             '{project.purpose}' => $this->projectPurpose,
+            // TODO: Add package info, php version, laravel version, existing approaches, directory structure, models? General Laravel guidance that applies to all projects somehow? 'Follow existing conventions - if you are creating or editing a file, check sibling files for structure/approach/naming
+//            TODO: Add project structure / relevant models / etc.. ? Kind of like Claude's /init, but for every Laravel developer regardless of IDE ? But if they already have that in Claude.md then that's gonna be doubling up and wasting tokens
         ])]);
 
         if (str_contains(config('app.url'), '.test') && $this->isHerdInstalled()) {
@@ -116,44 +127,61 @@ protected function compose(): string
             ]));
         }
 
-        // TODO: Improve • this is a horrible way to do this
+        if ($this->installingStyleGuidelines()) {
+            $composed->put('laravel/style', $this->guideline('laravel/style.md'));
+        }
+
+        // Add all core.md and version specific docs for Roster supported packages
+        // We don't add guidelines for packages not supported by Roster right now
+        foreach ($this->roster->packages() as $package) {
+            $guidelineDir = str_replace('_', '-', strtolower($package->name()));
+            $coreGuidelines = $this->guideline($guidelineDir . '/core.md'); // Add core
+            if ($coreGuidelines) {
+                $composed->put($guidelineDir . '/core', $coreGuidelines);
+            }
 
-        if ($this->roster->usesVersion(Packages::INERTIA_LARAVEL, '2.0.0', '>=')) {
-            $composed->put('inertiajs-laravel/core', $this->guideline('inertiajs-laravel/core.md', []));
-            $composed->put('inertiajs-laravel/v2', $this->guidelines('inertiajs-laravel/2/'));
+            $composed->put(
+                $guidelineDir . '/v' . $package->majorVersion(),
+                $this->guidelines($guidelineDir . '/' . $package->majorVersion())
+            );
         }
 
-        if ($this->shouldEnforceTests()) {
+        if ($this->enforceTests) {
             $composed->put('tests', $this->guideline('enforce-tests.md'));
         }
-        return $composed->map(fn($content, $key) => "# {$key}\n{$content}\n")
+
+        return $composed->whereNotNull()->map(fn($content, $key) => "# {$key}\n{$content}\n")
             ->join("\n\n====\n\n");
     }
 
-    protected function guidelines(string $dirPath, array $replacements = []): string
+    protected function guidelines(string $dirPath, array $replacements = []): ?string
     {
         $dirPath = str_replace('/', DIRECTORY_SEPARATOR, __DIR__ . '/../../.ai/' . $dirPath);
-        $finder = Finder::create()
-            ->files()
-            ->in($dirPath)
-            ->name('*.md');
+        try {
+            $finder = Finder::create()
+                ->files()
+                ->in($dirPath)
+                ->name('*.md');
+        } catch (DirectoryNotFoundException $e) {
+            return null;
+        }
 
         $guidelines = '';
         foreach ($finder as $file) {
-            $guidelines .= $this->guideline($file->getRealPath(), $replacements);
+            $guidelines .= $this->guideline($file->getRealPath(), $replacements) ?? '';
         }
 
         return $guidelines;
     }
 
-    protected function guideline(string $path, array $replacements = []): string
+    protected function guideline(string $path, array $replacements = []): ?string
     {
         if (!file_exists($path)) {
             $path = str_replace('/', DIRECTORY_SEPARATOR, __DIR__ . '/../../.ai/' . $path);
         }
 
         if (!file_exists($path)) {
-            throw new \Exception("$path does not exist");
+            return null;
         }
 
         $contents = file_get_contents($path);
@@ -300,13 +328,13 @@ private function intro()
 HEADER
         );
         intro('✦ Laravel Boost :: Install :: We Must Ship ✦');
-        $this->line(' Let\'s setup Laravel Boost in your IDEs for ' . $this->colors->bgYellow($this->colors->black($this->projectName)));
+        $this->line(' Let\'s give ' . $this->colors->bgYellow($this->colors->black($this->projectName)) . ' a Boost');
     }
 
     protected function projectPurpose(): string
     {
         return text(
-            label: 'What does this project do? (optional)',
+            label: sprintf('What does %s project do? (optional)', $this->projectName),
             placeholder: 'i.e. SaaS platform selling concert tickets, integrates with Stripe and Twilio, lots of CS using Nova backend',
             hint: 'This helps guides AI. How would you explain it to a new developer?'
         );
@@ -431,7 +459,7 @@ protected function agentsToInstallTo(): Collection
         ksort($agents);
 
         $selectedAgentClasses = collect(multiselect(
-            label: 'Which agents need AI guidelines?',
+            label: sprintf('Which agents need AI guidelines for %s?', $this->projectName),
             options: $agents,
             default: ['Laravel\\Boost\\Install\\Agents\\ClaudeCode'],//array_keys($agents),
             scroll: 4, // TODO: use detection to auto-select
@@ -496,6 +524,21 @@ protected function enactGuidelines(string $composedAiGuidelines): void
 
     protected function installingGuidelines(): bool
     {
-        return in_array('ai_guidelines', $this->boostToInstall);
+        return in_array('ai_guidelines', $this->boostToInstall, true);
+    }
+
+    protected function installingStyleGuidelines(): bool
+    {
+        return in_array('style_guidelines', $this->boostToInstall, true);
+    }
+
+    protected function installingMcp(): bool
+    {
+        return in_array('mcp_server', $this->boostToInstall, true);
+    }
+
+    protected function installingHerdMcp(): bool
+    {
+        return in_array('herd_mcp', $this->boostToInstall, true);
     }
 }

README.md

@@ -5,7 +5,7 @@
 // We give Agents AI Rules
 interface Agent
 {
-    public function path(): string;
+    public function guidelinesPath(): string;
 
     public function frontmatter(): bool;
 }

src/Console/InstallCommand.php

@@ -7,10 +7,5 @@ interface Ide
 {
     // Things to note: supports relative (absolute path required)? global mcp only? Prefer local file, but if global only we have to add the project name to the server name
 
-    /**
-     * Install MCP server to this IDE.
-     * Should be safe to re-run.
-     * Should work well with others.
-     */
-    public function installMcp(string $command, array $args): bool;
+    
 }

src/Contracts/Agent.php

@@ -3,11 +3,13 @@
 namespace Laravel\Boost\Install\Agents;
 
 use Laravel\Boost\Contracts\Agent;
-use Laravel\Boost\Contracts\Ide;
+use Laravel\Boost\Install\Agents\ShellMcpIde;
 
-class ClaudeCode implements Agent, Ide
+class ClaudeCode extends ShellMcpIde implements Agent
 {
-    public function path(): string
+    protected string $shellCommand = 'claude mcp add laravel-boost {command} {args}';
+
+    public function guidelinesPath(): string
     {
         return 'CLAUDE.md';
     }
@@ -16,9 +18,4 @@ public function frontmatter(): bool
     {
         return false;
     }
-
-    public function installMcp(string $command, array $args): bool
-    {
-        return true;
-    }
 }

src/Contracts/Ide.php

@@ -6,7 +6,7 @@
 
 class Copilot implements Agent
 {
-    public function path(): string
+    public function guidelinesPath(): string
     {
         // VS Code supports multiple files in .github/instructions/
         // But, other IDEs don't
@@ -15,6 +15,9 @@ public function path(): string
 
     public function frontmatter(): bool
     {
+        // If we use the multi file approach we can use frontmatter
+        // In VSCode at least https://docs.github.com/en/copilot/how-tos/configure-custom-instructions/add-repository-instructions?tool=vscode
+        
         return false;
     }
 }