Finalizes

Author: nunomaduro

src/Install/GuidelineWriter.php

@@ -31,11 +31,11 @@ public function write(string $guidelines): int
         $filePath = $this->agent->guidelinesPath();
 
         $directory = dirname($filePath);
-        if (! is_dir($directory) && ! mkdir($directory, 0755, true)) {
+        if (! is_dir($directory) && ! @mkdir($directory, 0755, true)) {
             throw new RuntimeException("Failed to create directory: {$directory}");
         }
 
-        $handle = fopen($filePath, 'c+');
+        $handle = @fopen($filePath, 'c+');
         if (! $handle) {
             throw new RuntimeException("Failed to open file: {$filePath}");
         }

src/Support/Composer.php

@@ -6,9 +6,6 @@
 
 class Composer
 {
-    /**
-     * Get all packages directories listed in composer.json (both require and require-dev).
-     */
     public static function packagesDirectories(): array
     {
         return collect(static::packages())
@@ -40,9 +37,6 @@ public static function packages(): array
             ->toArray();
     }
 
-    /**
-     * Get all packages directories that contain Boost guidelines.
-     */
     public static function packagesDirectoriesWithBoostGuidelines(): array
     {
         return collect(Composer::packagesDirectories())

src/Support/Config.php

@@ -62,6 +62,15 @@ public function getHerdMcp(): bool
         return $this->get('herd_mcp', false);
     }
 
+    public function flush(): void
+    {
+        $path = base_path(self::FILE);
+
+        if (file_exists($path)) {
+            unlink($path);
+        }
+    }
+
     protected function get(string $key, mixed $default = null): mixed
     {
         $config = $this->all();

tests/Feature/Console/InstallCommandWslTest.php

@@ -8,7 +8,7 @@
 test('isRunningInWsl returns true when WSL_DISTRO_NAME is set', function (): void {
     putenv('WSL_DISTRO_NAME=Ubuntu');
 
-    $command = new InstallCommand(new Config());
+    $command = new InstallCommand(new Config);
     $reflection = new ReflectionClass($command);
     $method = $reflection->getMethod('isRunningInWsl');
 
@@ -18,7 +18,7 @@
 test('isRunningInWsl returns true when IS_WSL is set', function (): void {
     putenv('IS_WSL=1');
 
-    $command = new InstallCommand(new Config());
+    $command = new InstallCommand(new Config);
     $reflection = new ReflectionClass($command);
     $method = $reflection->getMethod('isRunningInWsl');
 
@@ -29,7 +29,7 @@
     putenv('WSL_DISTRO_NAME=Ubuntu');
     putenv('IS_WSL=true');
 
-    $command = new InstallCommand(new Config());
+    $command = new InstallCommand(new Config);
     $reflection = new ReflectionClass($command);
     $method = $reflection->getMethod('isRunningInWsl');
 
@@ -40,7 +40,7 @@
     putenv('WSL_DISTRO_NAME');
     putenv('IS_WSL');
 
-    $command = new InstallCommand(new Config());
+    $command = new InstallCommand(new Config);
     $reflection = new ReflectionClass($command);
     $method = $reflection->getMethod('isRunningInWsl');
 
@@ -51,7 +51,7 @@
     putenv('WSL_DISTRO_NAME=');
     putenv('IS_WSL=');
 
-    $command = new InstallCommand(new Config());
+    $command = new InstallCommand(new Config);
     $reflection = new ReflectionClass($command);
     $method = $reflection->getMethod('isRunningInWsl');
 

tests/Pest.php

@@ -13,9 +13,13 @@
 |
 */
 
+use Laravel\Boost\Support\Config;
 use Laravel\Mcp\Response;
 
-uses(Tests\TestCase::class)->in('Feature');
+uses(Tests\TestCase::class)->in('Unit', 'Feature')
+    ->beforeEach(function () {
+        (new Config)->flush();
+    });
 
 expect()->extend('isToolResult', fn () => $this->toBeInstanceOf(Response::class));
 

tests/Unit/Install/CodeEnvironment/CodeEnvironmentTest.php

@@ -21,10 +21,6 @@
     $this->strategy = Mockery::mock(DetectionStrategy::class);
 });
 
-afterEach(function (): void {
-    Mockery::close();
-});
-
 // Create a concrete test implementation for testing abstract methods
 class TestCodeEnvironment extends CodeEnvironment
 {

tests/Unit/Install/CodeEnvironmentsDetectorTest.php

@@ -11,10 +11,6 @@
     $this->detector = new CodeEnvironmentsDetector($this->container);
 });
 
-afterEach(function (): void {
-    Mockery::close();
-});
-
 test('discoverSystemInstalledCodeEnvironments returns detected programs', function (): void {
     // Create mock programs
     $program1 = Mockery::mock(CodeEnvironment::class);

tests/Unit/Install/Detection/CompositeDetectionStrategyTest.php

@@ -12,10 +12,6 @@
     $this->thirdStrategy = Mockery::mock(DetectionStrategy::class);
 });
 
-afterEach(function (): void {
-    Mockery::close();
-});
-
 test('returns true when first strategy succeeds', function (): void {
     $this->firstStrategy
         ->shouldReceive('detect')

tests/Unit/Install/Mcp/FileWriterTest.php

@@ -4,16 +4,13 @@
 
 namespace Tests\Unit\Install\Mcp;
 
+use Illuminate\Contracts\Filesystem\Filesystem;
 use Illuminate\Support\Facades\File;
 use Illuminate\Support\Str;
 use Laravel\Boost\Install\Mcp\FileWriter;
 use Mockery;
 use ReflectionClass;
 
-beforeEach(function (): void {
-    Mockery::close();
-});
-
 test('constructor sets file path', function (): void {
     $writer = new FileWriter('/path/to/mcp.json');
     expect($writer)->toBeInstanceOf(FileWriter::class);
@@ -283,8 +280,7 @@
 test("injecting twice into existing JSON 5 doesn't cause duplicates", function (): void {
     $capturedContent = '';
 
-    File::clearResolvedInstances();
-    File::partialMock();
+    File::swap(Mockery::mock(Filesystem::class));
 
     File::shouldReceive('ensureDirectoryExists')->once();
     File::shouldReceive('exists')->andReturn(true);
@@ -313,8 +309,7 @@
 
     $newContent = $capturedContent;
 
-    File::clearResolvedInstances();
-    File::partialMock();
+    File::swap(Mockery::mock(Filesystem::class));
 
     File::shouldReceive('ensureDirectoryExists')->once();
     File::shouldReceive('exists')->andReturn(true);
@@ -388,8 +383,7 @@
 function mockFileOperations(bool $fileExists = false, string $content = '{}', bool $writeSuccess = true, ?string &$capturedPath = null, ?string &$capturedContent = null): void
 {
     // Clear any existing File facade mock
-    File::clearResolvedInstances();
-    File::partialMock();
+    File::swap(Mockery::mock(Filesystem::class));
 
     File::shouldReceive('ensureDirectoryExists')->once();
     File::shouldReceive('exists')->andReturn($fileExists);

tests/Unit/Support/ComposerTest.php

@@ -0,0 +1,66 @@
+<?php
+
+use Laravel\Boost\Support\Config;
+
+afterEach(function () {
+    (new Config(__DIR__))->flush();
+});
+
+it('may store and retrieve guidelines', function (): void {
+    $config = new Config(__DIR__);
+
+    expect($config->getGuidelines())->toBeEmpty();
+
+    $guidelines = [
+        'guideline_1',
+        'guideline_2',
+    ];
+
+    $config->setGuidelines($guidelines);
+
+    expect($config->getGuidelines())->toEqual($guidelines);
+});
+
+it('may store and retrieve agents', function (): void {
+    $config = new Config(__DIR__);
+
+    expect($config->getAgents())->toBeEmpty();
+
+    $agents = [
+        'agent_1',
+        'agent_2',
+    ];
+
+    $config->setAgents($agents);
+
+    expect($config->getAgents())->toEqual($agents);
+});
+
+it('may store and retrieve editors', function (): void {
+    $config = new Config(__DIR__);
+
+    expect($config->getEditors())->toBeEmpty();
+
+    $editors = [
+        'editor_1',
+        'editor_2',
+    ];
+
+    $config->setEditors($editors);
+
+    expect($config->getEditors())->toEqual($editors);
+});
+
+it('may store and retrieve herd mcp installation status', function (): void {
+    $config = new Config(__DIR__);
+
+    expect($config->getHerdMcp())->toBeFalse();
+
+    $config->setHerdMcp(true);
+
+    expect($config->getHerdMcp())->toBeTrue();
+
+    $config->setHerdMcp(false);
+
+    expect($config->getHerdMcp())->toBeFalse();
+});