[8.x] Remove 204 response and instead be explicit with ignores (#1187)

* Update UserController.php

* Update Browser.php

* Update UserController.php

* Update Browser.php

* some kinda test

* void

Author: jackbayliss

src/Browser.php

@@ -85,6 +85,15 @@ class Browser
      */
     public static $storeSourceAt;
 
+    /**
+     * Console log messages to ignore when storing console logs.
+     *
+     * @var array
+     */
+    public static $ignoreConsoleMessages = [
+        'favicon.ico',
+    ];
+
     /**
      * The browsers that support retrieving logs.
      *
@@ -481,7 +490,10 @@ public function screenshotElement($selector, $name)
     public function storeConsoleLog($name)
     {
         if (in_array($this->driver->getCapabilities()->getBrowserName(), static::$supportsRemoteLogs)) {
-            $console = $this->driver->manage()->getLog('browser');
+            $console = collect($this->driver->manage()->getLog('browser'))
+                ->reject(fn ($entry) => Str::contains($entry['message'] ?? '', static::$ignoreConsoleMessages))
+                ->values()
+                ->all();
 
             if (! empty($console)) {
                 $filePath = sprintf('%s/%s.log', rtrim(static::$storeConsoleLogAt, '/'), $name);

src/Http/Controllers/UserController.php

@@ -33,7 +33,7 @@ public function user($guard = null)
      *
      * @param  string  $userId
      * @param  string|null  $guard
-     * @return \Illuminate\Http\Response
+     * @return void
      */
     public function login($userId, $guard = null)
     {
@@ -46,15 +46,13 @@ public function login($userId, $guard = null)
                     : $provider->retrieveById($userId);
 
         Auth::guard($guard)->login($user);
-
-        return response(status: 204);
     }
 
     /**
      * Log the user out of the application.
      *
      * @param  string|null  $guard
-     * @return \Illuminate\Http\Response
+     * @return void
      */
     public function logout($guard = null)
     {
@@ -63,8 +61,6 @@ public function logout($guard = null)
         Auth::guard($guard)->logout();
 
         Session::forget('password_hash_'.$guard);
-
-        return response(status: 204);
     }
 
     /**

tests/Unit/BrowserTest.php

@@ -314,6 +314,21 @@ public function test_can_enable_fit_on_failure()
         $this->assertTrue($this->browser->fitOnFailure);
     }
 
+    public function test_ignores_favicon_console_messages()
+    {
+        $driver = m::mock(stdClass::class);
+        $driver->shouldReceive('manage->getLog')->with('browser')->andReturn([
+            ['message' => 'https://example.com/favicon.ico - Failed to load resource: the server responded with a status of 404 ()', 'level' => 'SEVERE'],
+        ]);
+        $driver->shouldReceive('getCapabilities->getBrowserName')->andReturn(WebDriverBrowserType::CHROME);
+        $browser = new Browser($driver);
+        Browser::$storeConsoleLogAt = sys_get_temp_dir();
+
+        $browser->storeConsoleLog('ignore-test');
+
+        $this->assertFileDoesNotExist(sys_get_temp_dir().'/ignore-test.log');
+    }
+
     public function test_source_code_can_be_stored()
     {
         $this->driver->shouldReceive('getPageSource')->andReturn('source content');